|
|
If we decide not to apply the patch Rafael suggested here:
http://breakpad.appspot.com/502003/
then we should fix the bug in the test he points out in that issue, namely:
The test 'Dwarf2DIEHandler.FindAndSkipChildren' in src/common/dwarf/dwarf2diehandler_unittest.cc pushes test values for attributes and forms on the wrong attribute list. However, since the same AttributeList instance is used to both pass the values to the code under test, and to check the value received by the mock DIE handlers, the tests pass anyway --- they just operate on different values than intended.
This patch places the test values in the correct attribute list; the test continues to pass, and no change is needed to the code under test.
|
