Issue 6907050: version: take series out of FORCE-VERSION

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6907050: version: take series out of FORCE-VERSION

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by niemeyer

Modified:
11 years, 4 months ago

Reviewers:
mp+138763, fwereade, rog

Visibility:
Public.

Description

version: take series out of FORCE-VERSION https://code.launchpad.net/~niemeyer/juju-core/force-version-number-only/+merge/138763 (do not edit description out of merge proposal)

Patch Set 2 : version: take series out of FORCE-VERSION #

Patch Set 3 : version: take series out of FORCE-VERSION #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -16 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/upgradejuju.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	cmd/juju/upgradejuju_test.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	environs/jujutest/livetests.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	environs/tools.go	View	1	6 chunks	+11 lines, -9 lines	0 comments	Download
M	environs/tools_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	version/version.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rog

LGTM https://codereview.appspot.com/6907050/diff/1/environs/tools.go File environs/tools.go (right): https://codereview.appspot.com/6907050/diff/1/environs/tools.go#newcode85 environs/tools.go:85: // as having the given version number. s/as ...

11 years, 4 months ago (2012-12-07 16:14:28 UTC) #2

niemeyer

Please take a look. https://codereview.appspot.com/6907050/diff/1/environs/tools.go File environs/tools.go (right): https://codereview.appspot.com/6907050/diff/1/environs/tools.go#newcode85 environs/tools.go:85: // as having the given ...

11 years, 4 months ago (2012-12-07 17:25:37 UTC) #3

niemeyer

11 years, 4 months ago (2012-12-07 17:49:51 UTC) #5

*** Submitted:

version: take series out of FORCE-VERSION

R=rog, fwereade
CC=
https://codereview.appspot.com/6907050

Expand All Messages | Collapse All Messages