Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(813)

Issue 6907050: version: take series out of FORCE-VERSION

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by niemeyer
Modified:
9 years, 1 month ago
Reviewers:
mp+138763, fwereade, rog
Visibility:
Public.

Description

version: take series out of FORCE-VERSION https://code.launchpad.net/~niemeyer/juju-core/force-version-number-only/+merge/138763 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : version: take series out of FORCE-VERSION #

Patch Set 3 : version: take series out of FORCE-VERSION #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/upgradejuju.go View 1 chunk +2 lines, -2 lines 0 comments Download
M cmd/juju/upgradejuju_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M environs/jujutest/livetests.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/tools.go View 1 6 chunks +11 lines, -9 lines 0 comments Download
M environs/tools_test.go View 1 chunk +1 line, -1 line 0 comments Download
M version/version.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
niemeyer
Please take a look.
9 years, 1 month ago (2012-12-07 15:57:03 UTC) #1
rog
LGTM https://codereview.appspot.com/6907050/diff/1/environs/tools.go File environs/tools.go (right): https://codereview.appspot.com/6907050/diff/1/environs/tools.go#newcode85 environs/tools.go:85: // as having the given version number. s/as ...
9 years, 1 month ago (2012-12-07 16:14:28 UTC) #2
niemeyer
Please take a look. https://codereview.appspot.com/6907050/diff/1/environs/tools.go File environs/tools.go (right): https://codereview.appspot.com/6907050/diff/1/environs/tools.go#newcode85 environs/tools.go:85: // as having the given ...
9 years, 1 month ago (2012-12-07 17:25:37 UTC) #3
fwereade
LGTM
9 years, 1 month ago (2012-12-07 17:31:08 UTC) #4
niemeyer
9 years, 1 month ago (2012-12-07 17:49:51 UTC) #5
*** Submitted:

version: take series out of FORCE-VERSION

R=rog, fwereade
CC=
https://codereview.appspot.com/6907050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b