LGTM with one thought https://codereview.appspot.com/6904070/diff/1/google-oauth-client-java7/src/main/java/com/google/api/client/extensions/java7/auth/oauth2/FileCredentialStore2.java File google-oauth-client-java7/src/main/java/com/google/api/client/extensions/java7/auth/oauth2/FileCredentialStore2.java (right): https://codereview.appspot.com/6904070/diff/1/google-oauth-client-java7/src/main/java/com/google/api/client/extensions/java7/auth/oauth2/FileCredentialStore2.java#newcode31 google-oauth-client-java7/src/main/java/com/google/api/client/extensions/java7/auth/oauth2/FileCredentialStore2.java:31: public class FileCredentialStore2 extends FileCredentialStore ...
11 years, 4 months ago
(2012-12-10 19:18:34 UTC)
#2
LGTM with one thought
https://codereview.appspot.com/6904070/diff/1/google-oauth-client-java7/src/m...
File
google-oauth-client-java7/src/main/java/com/google/api/client/extensions/java7/auth/oauth2/FileCredentialStore2.java
(right):
https://codereview.appspot.com/6904070/diff/1/google-oauth-client-java7/src/m...
google-oauth-client-java7/src/main/java/com/google/api/client/extensions/java7/auth/oauth2/FileCredentialStore2.java:31:
public class FileCredentialStore2 extends FileCredentialStore {
[optional] I always disliked "XXX2" as a class name because its not at all
intuitive what the difference is without having to go and check the Javadoc.
Unfortunately, its hard to think of a good alternative. FileCredentialStoreJava7
is the only other thing that comes to my mind.
Issue 6904070: oauth issue 61: Java 7 implementation of FileCredentialStore
(Closed)
Created 11 years, 4 months ago by yanivi
Modified 11 years, 4 months ago
Reviewers: ngmiceli
Base URL: https://google-oauth-java-client.googlecode.com/hg/
Comments: 1