Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3185)

Issue 6904070: oauth issue 61: Java 7 implementation of FileCredentialStore (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by yanivi
Modified:
11 years, 4 months ago
Reviewers:
ngmiceli
CC:
rmistry
Base URL:
https://google-oauth-java-client.googlecode.com/hg/
Visibility:
Public.

Description

oauth issue 61: Java 7 implementation of FileCredentialStore

Patch Set 1 #

Total comments: 1

Patch Set 2 : rename to Java7 suffix and add a unit test #

Patch Set 3 : minor #

Patch Set 4 : minor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+892 lines, -3 lines) Patch
M google-oauth-client-assembly/pom.xml View 1 chunk +4 lines, -0 lines 0 comments Download
M google-oauth-client-assembly/readme.html View 2 chunks +3 lines, -0 lines 0 comments Download
M google-oauth-client-java6/src/test/java/com/google/api/client/extensions/java6/auth/oauth2/FileCredentialStoreTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
A google-oauth-client-java7/.classpath View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
A google-oauth-client-java7/.project View 1 chunk +17 lines, -0 lines 0 comments Download
A google-oauth-client-java7/.settings/org.eclipse.jdt.core.prefs View 1 chunk +379 lines, -0 lines 0 comments Download
A google-oauth-client-java7/.settings/org.eclipse.jdt.ui.prefs View 1 chunk +119 lines, -0 lines 0 comments Download
A google-oauth-client-java7/pom.xml View 1 chunk +74 lines, -0 lines 0 comments Download
A google-oauth-client-java7/src/main/java/com/google/api/client/extensions/java7/auth/oauth2/FileCredentialStoreJava7.java View 1 1 chunk +45 lines, -0 lines 0 comments Download
A google-oauth-client-java7/src/main/java/com/google/api/client/extensions/java7/auth/oauth2/package-info.java View 1 chunk +27 lines, -0 lines 0 comments Download
A google-oauth-client-java7/src/test/java/com/google/api/client/extensions/java6/auth/oauth2/FileCredentialStoreJava7Test.java View 1 1 chunk +201 lines, -0 lines 0 comments Download
M jdiff.xml View 1 chunk +1 line, -0 lines 0 comments Download
M pom.xml View 4 chunks +11 lines, -1 line 0 comments Download
M release.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
yanivi
11 years, 4 months ago (2012-12-10 17:39:05 UTC) #1
ngmiceli
LGTM with one thought https://codereview.appspot.com/6904070/diff/1/google-oauth-client-java7/src/main/java/com/google/api/client/extensions/java7/auth/oauth2/FileCredentialStore2.java File google-oauth-client-java7/src/main/java/com/google/api/client/extensions/java7/auth/oauth2/FileCredentialStore2.java (right): https://codereview.appspot.com/6904070/diff/1/google-oauth-client-java7/src/main/java/com/google/api/client/extensions/java7/auth/oauth2/FileCredentialStore2.java#newcode31 google-oauth-client-java7/src/main/java/com/google/api/client/extensions/java7/auth/oauth2/FileCredentialStore2.java:31: public class FileCredentialStore2 extends FileCredentialStore ...
11 years, 4 months ago (2012-12-10 19:18:34 UTC) #2
yanivi
Rename done. Also added a unit test, including a Java 7 only test for symbolic ...
11 years, 4 months ago (2012-12-10 21:12:33 UTC) #3
ngmiceli
11 years, 4 months ago (2012-12-10 21:38:31 UTC) #4
On 2012/12/10 21:12:33, yanivi wrote:
> Rename done.  Also added a unit test, including a Java 7 only test for
symbolic
> link.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b