Issue 6904062: code review 6904062: go.crypto: remove cipher.Reset()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6904062: code review 6904062: go.crypto: remove cipher.Reset()

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by dgryski

Modified:
11 years, 4 months ago

Reviewers:

CC:
agl1, golang-dev

Visibility:
Public.

Description

go.crypto: remove cipher.Reset() The go.crypto repo was missed when this function was removed from the ciphers in the standard library.

Patch Set 1 #

Patch Set 2 : diff -r b2b2ae1f5140 https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r b2b2ae1f5140 https://code.google.com/p/go.crypto/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -55 lines)			Patch
M	blowfish/cipher.go	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
M	cast5/cast5.go	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	twofish/twofish.go	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download
M	xtea/cipher.go	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	xtea/xtea_test.go	View	1	1 chunk	+0 lines, -17 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dgryski

Hello agl@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/

11 years, 4 months ago (2012-12-10 05:23:38 UTC) #1

agl1

11 years, 4 months ago (2012-12-10 16:01:09 UTC) #2

*** Submitted as
https://code.google.com/p/go/source/detail?r=e94c385a2926&repo=crypto ***

go.crypto: remove cipher.Reset()

The go.crypto repo was missed when this function was removed from the
ciphers in the standard library.

R=agl
CC=golang-dev
https://codereview.appspot.com/6904062

Committer: Adam Langley <agl@golang.org>

Expand All Messages | Collapse All Messages