Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10060)

Issue 6904043: Backported r185234 from trunk (r194264 from google/gcc-4_7).

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by asharif
Modified:
11 years, 4 months ago
Reviewers:
shenhan, Diego Novillo, cmtice, carrot
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/gcc-4_7-mobile/
Visibility:
Public.

Description

2012-12-03 Ahmad Sharif <asharif@google.com> Backport r185231 from trunk. 2012-03-12 Richard Guenther <rguenther@suse.de> * gthr.h (__GTHREAD_MUTEX_INIT_FUNCTION): Adjust specification. * gthr-posix.h (__GTHREAD_MUTEX_INIT_FUNCTION): Define. (__gthread_mutex_init_function): New function. * gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Define. PR gcov/49484 * libgcov.c: Include gthr.h. (__gcov_flush_mx): New global variable. (init_mx, init_mx_once): New functions. (__gcov_flush): Protect self with a mutex. (__gcov_fork): Re-initialize mutex after forking. * unwind-dw2-fde.c: Change condition under which to use __GTHREAD_MUTEX_INIT_FUNCTION.

Patch Set 1 #

Patch Set 2 : Updated ChangeLog.google-4_7-mobile. #

Patch Set 3 : Removed ChangeLog changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -5 lines) Patch
M . View 0 chunks +-1 lines, --1 lines 0 comments Download
M gcc View 0 chunks +-1 lines, --1 lines 0 comments Download
M gcc/testsuite/gcc.target/powerpc/ppc-round.c View 0 chunks +-1 lines, --1 lines 0 comments Download
libgcc/ChangeLog.google-4_7 View 1 chunk +20 lines, -0 lines 0 comments Download
M libgcc/gthr.h View 1 chunk +5 lines, -4 lines 0 comments Download
M libgcc/gthr-posix.h View 2 chunks +9 lines, -0 lines 0 comments Download
M libgcc/gthr-single.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M libgcc/libgcov.c View 4 chunks +31 lines, -1 line 0 comments Download
M libgcc/unwind-dw2-fde.c View 2 chunks +1 line, -4 lines 0 comments Download
M libjava/classpath View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6
asharif
Please review this backport needed to enable PGO for Chrome.
11 years, 4 months ago (2012-12-06 20:18:02 UTC) #1
shenhan
On 2012/12/06 20:18:02, asharif wrote: > Please review this backport needed to enable PGO for ...
11 years, 4 months ago (2012-12-06 21:19:17 UTC) #2
asharif
On 2012/12/06 21:19:17, shenhan wrote: > On 2012/12/06 20:18:02, asharif wrote: > > Please review ...
11 years, 4 months ago (2012-12-06 21:51:54 UTC) #3
Diego Novillo
On Thu, Dec 6, 2012 at 4:51 PM, <asharif@chromium.org> wrote: > I don't think the ...
11 years, 4 months ago (2012-12-06 22:02:16 UTC) #4
asharif
On 2012/12/06 22:02:16, Diego Novillo wrote: > On Thu, Dec 6, 2012 at 4:51 PM, ...
11 years, 4 months ago (2012-12-07 00:29:39 UTC) #5
shenhan
11 years, 4 months ago (2012-12-07 00:33:01 UTC) #6
On 2012/12/07 00:29:39, asharif wrote:
> On 2012/12/06 22:02:16, Diego Novillo wrote:
> > On Thu, Dec 6, 2012 at 4:51 PM,  <mailto:asharif@chromium.org> wrote:
> > 
> > > I don't think the rule is to *only* update ChangeLog.google*. The rule
> > > is to update ChangeLog, but also update ChangeLog.google*.
> > 
> > Just ChangeLog.google*, actually.  When cherry picking revisions from
> > other branches, it's better not to update ChangeLog.  It's not really
> > necessary and it will actually cause merge conflicts later.  I'll
> > clarify the developer notes.
> > 
> > 
> > Thanks.  Diego.
> 
> Done.
> 
> I have removed the ChangeLog chunk. PTAL.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b