Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(118)

Issue 6903059: code review 6903059: cmd/gc: don't import the same package multiple times. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by remyoudompheng
Modified:
9 years, 7 months ago
Reviewers:
CC:
golang-dev, dfc, DMorsing, rsc
Visibility:
Public.

Description

cmd/gc: don't import the same package multiple times. Implementation suggested by DMorsing.

Patch Set 1 #

Patch Set 2 : diff -r 970e6f92841d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 970e6f92841d https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 970e6f92841d https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r a3a847781593 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/cmd/gc/go.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/lex.c View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 13
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 8 months ago (2012-12-09 19:04:10 UTC) #1
dfc
On 2012/12/09 19:04:10, remyoudompheng wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
9 years, 8 months ago (2012-12-09 20:22:01 UTC) #2
DMorsing
Nice. However, You're still reading in the package file. I worked on this independently and ...
9 years, 8 months ago (2012-12-09 20:23:48 UTC) #3
remyoudompheng
On 2012/12/09 20:23:48, DMorsing wrote: > if(importpkg->imported) { > file = strdup(namebuf); > p = ...
9 years, 8 months ago (2012-12-09 20:40:02 UTC) #4
rsc
Sounds promising. Let me know when you've processed Daniel's suggestions.
9 years, 8 months ago (2012-12-10 03:33:08 UTC) #5
dfc
On 2012/12/10 03:33:08, rsc wrote: > Sounds promising. Let me know when you've processed Daniel's ...
9 years, 8 months ago (2012-12-11 01:56:45 UTC) #6
DMorsing
On 2012/12/11 01:56:45, dfc wrote: > The pandaboard has 1gb of ram, so swapping is ...
9 years, 8 months ago (2012-12-11 09:41:36 UTC) #7
dfc
A sound explanation. I will retest once the next patch set lands. On 11/12/2012, at ...
9 years, 8 months ago (2012-12-11 11:33:33 UTC) #8
remyoudompheng
Hello golang-dev@googlegroups.com, dave@cheney.net, daniel.morsing@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 8 months ago (2012-12-11 22:00:16 UTC) #9
DMorsing
LGTM
9 years, 8 months ago (2012-12-11 22:25:52 UTC) #10
dfc
On 2012/12/11 22:00:16, remyoudompheng wrote: > Hello mailto:golang-dev@googlegroups.com, mailto:dave@cheney.net, mailto:daniel.morsing@gmail.com, > mailto:rsc@golang.org (cc: mailto:golang-dev@googlegroups.com), > ...
9 years, 8 months ago (2012-12-11 22:31:36 UTC) #11
rsc
LGTM Fantastic.
9 years, 8 months ago (2012-12-12 03:59:04 UTC) #12
remyoudompheng
9 years, 8 months ago (2012-12-12 07:53:12 UTC) #13
*** Submitted as https://code.google.com/p/go/source/detail?r=f593af463c17 ***

cmd/gc: don't import the same package multiple times.

Implementation suggested by DMorsing.

R=golang-dev, dave, daniel.morsing, rsc
CC=golang-dev
https://codereview.appspot.com/6903059
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b