code review 6903057: net/http: fix text for ErrBodyReadAfterClose

net/http: fix text for ErrBodyReadAfterClose

Can happen in both request and response.
Also use it in one place that wasn't.

Fixes issue 3997.

[rsc, 2012-12-09 18:31:08]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2012-12-09 18:40:18]

LGTM
 On Dec 9, 2012 1:31 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> net/http: fix text for ErrBodyReadAfterClose
>
> Can happen in both request and response.
> Also use it in one place that wasn't.
>
> Fixes issue 3997.
>
> Please review this at
https://codereview.appspot.**com/6903057/<https://codereview.appspot.com/6903...
>
> Affected files:
>   M src/pkg/net/http/server.go
>   M src/pkg/net/http/transfer.go
>
>
> Index: src/pkg/net/http/server.go
> ==============================**==============================**=======
> --- a/src/pkg/net/http/server.go
> +++ b/src/pkg/net/http/server.go
> @@ -302,7 +302,7 @@
>
>  func (ecr *expectContinueReader) Read(p []byte) (n int, err error) {
>         if ecr.closed {
> -               return 0, errors.New("http: Read after Close on request
> Body")
> +               return 0, ErrBodyReadAfterClose
>         }
>         if !ecr.resp.wroteContinue && !ecr.resp.conn.hijacked() {
>                 ecr.resp.wroteContinue = true
> Index: src/pkg/net/http/transfer.go
> ==============================**==============================**=======
> --- a/src/pkg/net/http/transfer.go
> +++ b/src/pkg/net/http/transfer.go
> @@ -534,11 +534,11 @@
>         res *response // response writer for server requests, else nil
>  }
>
> -// ErrBodyReadAfterClose is returned when reading a Request Body after
> -// the body has been closed. This typically happens when the body is
> +// ErrBodyReadAfterClose is returned when reading a Request or Response
> +// Body after the body has been closed. This typically happens when the
> body is
>  // read after an HTTP Handler calls WriteHeader or Write on its
>  // ResponseWriter.
> -var ErrBodyReadAfterClose = errors.New("http: invalid Read on closed
> request Body")
> +var ErrBodyReadAfterClose = errors.New("http: invalid Read on closed
> Body")
>
>  func (b *body) Read(p []byte) (n int, err error) {
>         if b.closed {
>
>
>

[rsc, 2012-12-10 06:42:15]

*** Submitted as https://code.google.com/p/go/source/detail?r=0e888189a5e2 ***

net/http: fix text for ErrBodyReadAfterClose

Can happen in both request and response.
Also use it in one place that wasn't.

Fixes issue 3997.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/6903057