Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(824)

Issue 69020044: code review 69020044: cmd/5a, cmd/5c, cmd/6a, cmd/6c, cmd/8a, cmd/8c, cmd/cc:... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by dave
Modified:
11 years, 3 months ago
Reviewers:
gobot, rsc
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

cmd/5a, cmd/5c, cmd/6a, cmd/6c, cmd/8a, cmd/8c, cmd/cc: support for Native Client From the original description in CL 15770043 The main change here is to consult $GOARCH. In 6c, when GOOS=nacl, some of the more complex addressing modes must be disabled, and the BP and R15 registers must not be used. See golang.org/s/go13nacl for design overview.

Patch Set 1 #

Patch Set 2 : diff -r bca0032e86af https://code.google.com/p/go #

Patch Set 3 : diff -r bca0032e86af https://code.google.com/p/go #

Patch Set 4 : diff -r bca0032e86af https://code.google.com/p/go #

Patch Set 5 : diff -r 1424452d7eb5 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -19 lines) Patch
M src/cmd/5a/lex.c View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/cmd/5c/swt.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/5c/txt.c View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/cmd/6a/lex.c View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/cmd/6c/reg.c View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/cmd/6c/sgen.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/6c/swt.c View 1 4 chunks +21 lines, -1 line 0 comments Download
M src/cmd/6c/txt.c View 1 8 chunks +26 lines, -5 lines 0 comments Download
M src/cmd/8a/lex.c View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/cmd/8c/swt.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/8c/txt.c View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/cmd/cc/cc.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/cmd/cc/lex.c View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6
dave_cheney.net
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 3 months ago (2014-02-26 09:22:37 UTC) #1
dave_cheney.net
Tested on darwin/amd64, linux/arm and linux/386.
11 years, 3 months ago (2014-02-26 09:23:49 UTC) #2
gobot
R=rsc@golang.org (assigned by dave@cheney.net)
11 years, 3 months ago (2014-02-26 09:26:39 UTC) #3
rsc
LGTM
11 years, 3 months ago (2014-02-26 14:55:46 UTC) #4
dave_cheney.net
*** Submitted as https://code.google.com/p/go/source/detail?r=8e2f6e31a688 *** cmd/5a, cmd/5c, cmd/6a, cmd/6c, cmd/8a, cmd/8c, cmd/cc: support for Native ...
11 years, 3 months ago (2014-02-26 19:57:27 UTC) #5
gobot
11 years, 3 months ago (2014-02-26 20:20:08 UTC) #6
Message was sent while issue was closed.
This CL appears to have broken the windows-amd64 builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b