s3: add support for 409 responses

s3: add support for 409 responses

Required to fix LP 1042107

https://code.launchpad.net/~dave-cheney/goamz/004-send-409-conflict/+merge/138903

(do not edit description out of merge proposal)

[dave_cheney.net, 2012-12-10 05:35:34]

Please take a look.

[dave_cheney.net, 2012-12-10 05:36:26]

Please take a look.

[fwereade, 2012-12-10 07:26:13]

LGTM

[jameinel, 2012-12-10 08:38:24]

The change LGTM, but there are some small questions.
1) If you're changing the service to return 409, shouldn't there be a
corresponding client-side change that says "oh 409, that means it already exists
and I should just treat it as a duplicate".

2) Should we have something more like:
 s.emulate = "us-east-1"

Rather than a simple boolean s.emulateUSEast1? I'm thinking that eventually we
may find that USEast2 acts differently from USWest, vs  Asia, etc.

I realize that us-east-1 is the most tested at this point, but it does seem like
you want more than 1 bit of info for the parametrization of the test server.

[jameinel, 2012-12-10 08:40:09]

I see that I missed your patch to juju-core to handle the 409 case. Though I do
still wonder if it should be handled inside goamz rather than being handled in
juju-core.

[rog, 2012-12-10 10:30:07]

On 2012/12/10 08:38:24, jameinel wrote:
> 2) Should we have something more like:
>  s.emulate = "us-east-1"

i'd be happier with this too. that means we can add any
number of region-specific tweaks in the future. who
knows what differences there are?

[dave_cheney.net, 2012-12-10 23:39:03]

Please take a look.

[dave_cheney.net, 2012-12-10 23:40:16]

On 2012/12/10 23:39:03, dfc wrote:
> Please take a look.

Thanks for your comments. I have added a *Config style structure which can be
extended when we need more control over the s3test.Server.

[jameinel, 2012-12-11 05:14:08]

On 2012/12/10 23:40:16, dfc wrote:
> On 2012/12/10 23:39:03, dfc wrote:
> > Please take a look.
> 
> Thanks for your comments. I have added a *Config style structure which can be
> extended when we need more control over the s3test.Server.

LGTM. If you want, we could have a "useast1_config" and a "uswest1" or whatever.
So we don't have to figure out what the various configs actually mean. But
overall it seems fine to me.

[dave_cheney.net, 2012-12-11 05:15:18]

We could do that with a set of *Configs, ie

var USEast1 *Config
var USWest1 = &Config {
    Send409Conflict: true,
}

and so on ...

On Tue, Dec 11, 2012 at 4:14 PM,  <john.meinel@canonical.com> wrote:
> On 2012/12/10 23:40:16, dfc wrote:
>>
>> On 2012/12/10 23:39:03, dfc wrote:
>> > Please take a look.
>
>
>> Thanks for your comments. I have added a *Config style structure which
>
> can be
>>
>> extended when we need more control over the s3test.Server.
>
>
> LGTM. If you want, we could have a "useast1_config" and a "uswest1" or
> whatever. So we don't have to figure out what the various configs
> actually mean. But overall it seems fine to me.
>
> https://codereview.appspot.com/6901061/

[jameinel, 2012-12-11 05:40:02]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2012-12-11 9:15, Dave Cheney wrote:
> We could do that with a set of *Configs, ie
> 
> var USEast1 *Config var USWest1 = &Config { Send409Conflict: true, 
> }
> 
> and so on ...

That was my thought, yes.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (Cygwin)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iEYEARECAAYFAlDGxzkACgkQJdeBCYSNAAME8ACfU6V4r4Yb1pOfotGdi7yyRK/b
DCYAnRYRLboFTvnU2ftHUY3igXQI3gBs
=fCP5
-----END PGP SIGNATURE-----

[dave_cheney.net, 2012-12-11 05:42:02]

I'd rather leave that til we need it. The only use case at the moment
is for the made up 'test' region in the ec2 tests, which, by virtue of
being made up, won't match any exported constant we could add to
s3test.

On Tue, Dec 11, 2012 at 4:40 PM, John Arbash Meinel
<john.meinel@canonical.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 2012-12-11 9:15, Dave Cheney wrote:
>> We could do that with a set of *Configs, ie
>>
>> var USEast1 *Config var USWest1 = &Config { Send409Conflict: true,
>> }
>>
>> and so on ...
>
> That was my thought, yes.
>
> John
> =:->
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.12 (Cygwin)
> Comment: Using GnuPG with undefined - http://www.enigmail.net/
>
> iEYEARECAAYFAlDGxzkACgkQJdeBCYSNAAME8ACfU6V4r4Yb1pOfotGdi7yyRK/b
> DCYAnRYRLboFTvnU2ftHUY3igXQI3gBs
> =fCP5
> -----END PGP SIGNATURE-----

[dave_cheney.net, 2012-12-15 23:58:19]

*** Submitted:

s3: add support for 409 responses

Required to fix LP 1042107

R=fwereade, jameinel, rog
CC=
https://codereview.appspot.com/6901061