Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(296)

Issue 6898043: Serve static files using nginx

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by matthew.scott
Modified:
11 years, 4 months ago
Reviewers:
mp+138502
Visibility:
Public.

Description

Serve static files using nginx The charm now serves static files using nginx. There is another branch to fix the websocket URL in config.js, but until then, the URL will default to localhost. https://code.launchpad.net/~makyo/charms/precise/juju-gui/serve-static/+merge/138502 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Serve static files using nginx #

Total comments: 4

Patch Set 3 : Serve static files using nginx #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -12 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M config/juju-gui.conf.template View 1 chunk +1 line, -4 lines 0 comments Download
A config/nginx.conf.template View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M hooks/install View 2 chunks +9 lines, -2 lines 0 comments Download
M hooks/start View 1 2 4 chunks +14 lines, -4 lines 0 comments Download
M revision View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/deploy.test View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
matthew.scott
Please take a look.
11 years, 4 months ago (2012-12-06 16:31:03 UTC) #1
matthew.scott
Please take a look.
11 years, 4 months ago (2012-12-06 16:59:52 UTC) #2
hazmat
https://codereview.appspot.com/6898043/diff/3001/config/nginx.conf.template File config/nginx.conf.template (right): https://codereview.appspot.com/6898043/diff/3001/config/nginx.conf.template#newcode2 config/nginx.conf.template:2: listen 8888; we should just put this on 80. ...
11 years, 4 months ago (2012-12-06 17:32:37 UTC) #3
teknico
Nice branch. https://codereview.appspot.com/6898043/diff/3001/hooks/start File hooks/start (right): https://codereview.appspot.com/6898043/diff/3001/hooks/start#newcode50 hooks/start:50: build_dir += staging and 'debug' or 'prod' ...
11 years, 4 months ago (2012-12-07 15:11:53 UTC) #4
bac
Hope you don't mind a third review. Looks good with some small suggestions. Re-review not ...
11 years, 4 months ago (2012-12-10 13:43:51 UTC) #5
matthew.scott
11 years, 4 months ago (2012-12-10 16:05:06 UTC) #6
*** Submitted:

Serve static files using nginx

The charm now serves static files using nginx.  There is another branch to fix
the websocket URL in config.js, but until then, the URL will default to
localhost.

R=hazmat, teknico, bac
CC=
https://codereview.appspot.com/6898043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b