Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(604)

Issue 68980043: syscall: add mlock, munlock, mlockall, munlockall and mprotect to OSX (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by worr
Modified:
6 years, 3 months ago
Reviewers:
bradfitz
CC:
bradfitz, iant, golang-codereviews
Visibility:
Public.

Description

syscall: add mlock, munlock, mlockall, munlockall and mprotect to OSX Fixes Issue 7415

Patch Set 1 #

Patch Set 2 : used tip's mkall.sh #

Patch Set 3 : syscall: add mlock, munlock, mlockall, munlockall and mprotect to OSX #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -0 lines) Patch
M src/pkg/syscall/syscall_darwin.go View 1 chunk +5 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_darwin_386.go View 1 1 chunk +68 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_darwin_amd64.go View 1 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 15
bradfitz
This CL reverts unsafe.Pointer back to uintptrs. How did you generate it?
6 years, 10 months ago (2014-02-26 17:58:42 UTC) #1
worr
On 2014/02/26 17:58:42, bradfitz wrote: > This CL reverts unsafe.Pointer back to uintptrs. How did ...
6 years, 10 months ago (2014-02-26 18:20:54 UTC) #2
bradfitz
Please use the mkall.sh from tip. I'm guessing that is the problem. On Wed, Feb ...
6 years, 10 months ago (2014-02-26 18:23:40 UTC) #3
worr
On 2014/02/26 18:23:40, bradfitz wrote: > Please use the mkall.sh from tip. I'm guessing that ...
6 years, 10 months ago (2014-02-27 02:14:16 UTC) #4
bradfitz
LGTM
6 years, 10 months ago (2014-02-27 03:34:37 UTC) #5
bradfitz
Before we can accept this, do two things: 1) Submit a CLA. See: http://golang.org/doc/contribute.html#copyright and ...
6 years, 10 months ago (2014-02-27 03:37:23 UTC) #6
worr
syscall: add mlock, munlock, mlockall, munlockall and mprotect to OSX Fixes Issue 7415
6 years, 10 months ago (2014-02-27 04:11:14 UTC) #7
worr
Signed the CLA yesterday. Should be all set.
6 years, 10 months ago (2014-02-27 04:12:22 UTC) #8
bradfitz
Please update the CL description first. Run "hg change 68980043" and edit it.
6 years, 10 months ago (2014-02-27 04:13:09 UTC) #9
bradfitz
I see no record of your CLA submission. Under what email address did you submit ...
6 years, 10 months ago (2014-02-27 04:14:26 UTC) #10
worr
On 2014/02/27 04:14:26, bradfitz wrote: > I see no record of your CLA submission. > ...
6 years, 10 months ago (2014-02-27 04:18:03 UTC) #11
worr
On 2014/02/27 04:13:09, bradfitz wrote: > Please update the CL description first. > > Run ...
6 years, 10 months ago (2014-02-27 05:01:33 UTC) #12
iant
On Wed, Feb 26, 2014 at 9:01 PM, <ay1244@gmail.com> wrote: > On 2014/02/27 04:13:09, bradfitz ...
6 years, 10 months ago (2014-02-27 05:02:44 UTC) #13
worr
On 2014/02/27 05:02:44, iant wrote: > On Wed, Feb 26, 2014 at 9:01 PM, <mailto:ay1244@gmail.com> ...
6 years, 10 months ago (2014-02-27 05:06:27 UTC) #14
bradfitz
6 years, 10 months ago (2014-02-27 18:13:44 UTC) #15
*** Submitted as https://code.google.com/p/go/source/detail?r=c9d0aafffe33 ***

syscall: add mlock, munlock, mlockall, munlockall and mprotect to OSX

Fixes Issue 7415

LGTM=bradfitz
R=bradfitz, iant
CC=golang-codereviews
https://codereview.appspot.com/68980043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b