Issue 68960049: code review 68960049: net/http/cgi: serve 500, not 200, on invalid responses ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 68960049: code review 68960049: net/http/cgi: serve 500, not 200, on invalid responses ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by bradfitz

Modified:
11 years, 3 months ago

Reviewers:
adg

CC:
adg, golang-codereviews

Visibility:
Public.

Description

net/http/cgi: serve 500, not 200, on invalid responses from child processes Per RFC 3875 section 6 rules. Fixes Issue 7198

Patch Set 1 #

Patch Set 2 : diff -r 340da08f5f54 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 340da08f5f54 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b1e34388854e https://go.googlecode.com/hg/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -0 lines)			Patch
	M	src/pkg/net/http/cgi/host.go	View	1	4 chunks	+15 lines, -0 lines	0 comments	Download
	M	src/pkg/net/http/cgi/matryoshka_test.go	View	1	3 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 3 months ago (2014-03-06 19:50:52 UTC) #1

bradfitz

11 years, 3 months ago (2014-03-12 05:55:18 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=67e9191236b2 ***

net/http/cgi: serve 500, not 200, on invalid responses from child processes

Per RFC 3875 section 6 rules.

Fixes Issue 7198

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/68960049

Expand All Messages | Collapse All Messages