LGTM. Keep an eye on that line, it may change when NaCl lands. > On ...
11 years, 3 months ago
(2014-02-26 07:04:05 UTC)
#2
LGTM. Keep an eye on that line, it may change when NaCl lands.
> On 26 Feb 2014, at 17:30, iant@golang.org wrote:
>
> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> include: fix comment in link.h
>
> Please review this at https://codereview.appspot.com/68960044/
>
> Affected files (+1, -1 lines):
> M include/link.h
>
>
> Index: include/link.h
> ===================================================================
> --- a/include/link.h
> +++ b/include/link.h
> @@ -110,7 +110,7 @@
> uchar optab; // 5l
>
> char width; /* fake for DATA */
> - char mode; /* 16, 32, or 64 in 8l, 8l; internal use in 5g, 6g, 8g
*/
> + char mode; /* 16, 32, or 64 in 6l, 8l; internal use in 5g, 6g, 8g
*/
> };
>
> // prevent incompatible type signatures between liblink and 8l on Plan 9
>
>
> --
> You received this message because you are subscribed to the Google Groups
"golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Issue 68960044: code review 68960044: include: fix comment in link.h
(Closed)
Created 11 years, 3 months ago by iant
Modified 11 years, 3 months ago
Reviewers: gobot
Base URL:
Comments: 0