Issue 6894047: code review 6894047: goprotobuf: More efficient text marshaling, plus return...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6894047: code review 6894047: goprotobuf: More efficient text marshaling, plus return... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by dsymonds

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

goprotobuf: More efficient text marshaling, plus returning errors from underlying writer.

Patch Set 1 #

Patch Set 2 : diff -r 145dca00d164 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 145dca00d164 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 6b7bc9615fc6 https://code.google.com/p/goprotobuf #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+317 lines, -136 lines)			Patch
	M	proto/text.go	View	1	15 chunks	+258 lines, -132 lines	0 comments	Download
	M	proto/text_test.go	View	1	5 chunks	+59 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/goprotobuf

11 years, 5 months ago (2012-12-06 02:18:19 UTC) #1

dsymonds

11 years, 5 months ago (2012-12-06 03:05:53 UTC) #3

*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=25d6a6578cc5 ***

goprotobuf: More efficient text marshaling, plus returning errors from
underlying writer.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/6894047

Expand All Messages | Collapse All Messages