code review 6889052: fix build: remove a flaky test for now

fix build: remove a flaky test for now

[gri, 2012-12-06 17:46:43]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[gri, 2012-12-06 17:47:51]

*** Submitted as https://code.google.com/p/go/source/detail?r=a5efcd1675eb ***

fix build: remove a flaky test for now

R=rsc
CC=golang-dev
https://codereview.appspot.com/6889052

[bradfitz, 2012-12-06 17:49:59]

Not just GOARCH=386, but also the race builder, which is amd64.  And the
darwin-amd64 builder one of the times.

Depends on map iteration order?


On Thu, Dec 6, 2012 at 9:46 AM, <gri@golang.org> wrote:

> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> fix build: remove a flaky test for now
>
> Please review this at
https://codereview.appspot.**com/6889052/<https://codereview.appspot.com/6889...
>
> Affected files:
>   M src/pkg/exp/gotype/gotype_**test.go
>
>
> Index: src/pkg/exp/gotype/gotype_**test.go
> ==============================**==============================**=======
> --- a/src/pkg/exp/gotype/gotype_**test.go
> +++ b/src/pkg/exp/gotype/gotype_**test.go
> @@ -77,7 +77,7 @@
>         "crypto/md5",
>         "crypto/rand",
>         "crypto/rc4",
> -       "crypto/rsa",
> +       // "crypto/rsa", // investigate (GOARCH=386)
>         "crypto/sha1",
>         "crypto/sha256",
>         "crypto/sha512",
>
>
>

[gri, 2012-12-06 17:53:04]

Not sure actually. I've seen intermittent failures before but
yesterday I couldn't reproduce it. I'm aware it's not just 386, but I
wanted to make sure I _also_ test 386 next time.

Map iteration order might be an issue, but I thought I took care of
all of them. There appears to be one more failure elsewhere which I
have not seen before. May need one more iteration to get the build
clean again, but we'll get there shortly.

- gri

On Thu, Dec 6, 2012 at 9:49 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Not just GOARCH=386, but also the race builder, which is amd64.  And the
> darwin-amd64 builder one of the times.
>
> Depends on map iteration order?
>
>
> On Thu, Dec 6, 2012 at 9:46 AM, <gri@golang.org> wrote:
>>
>> Reviewers: rsc,
>>
>> Message:
>> Hello rsc (cc: golang-dev@googlegroups.com),
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go
>>
>>
>> Description:
>> fix build: remove a flaky test for now
>>
>> Please review this at https://codereview.appspot.com/6889052/
>>
>> Affected files:
>>   M src/pkg/exp/gotype/gotype_test.go
>>
>>
>> Index: src/pkg/exp/gotype/gotype_test.go
>> ===================================================================
>> --- a/src/pkg/exp/gotype/gotype_test.go
>> +++ b/src/pkg/exp/gotype/gotype_test.go
>> @@ -77,7 +77,7 @@
>>         "crypto/md5",
>>         "crypto/rand",
>>         "crypto/rc4",
>> -       "crypto/rsa",
>> +       // "crypto/rsa", // investigate (GOARCH=386)
>>         "crypto/sha1",
>>         "crypto/sha256",
>>         "crypto/sha512",
>>
>>
>