Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(638)

Issue 6886049: Add buildout environment support.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by rharding
Modified:
11 years, 4 months ago
Reviewers:
hazmat, abentley-home, mp+138537
Visibility:
Public.

Description

Add buildout environment support. WARNING: not all jobs/scripts and code worked so we might be missing deps that need to be added to the download cache. Adds buildout with a download-cache. It's a split repo and auto pulls during installing dependencies. Defaults to locked down and will only install from download cache. Missing deps need to be added there first and updated in versions.cfg. Adds a bunch of new makefile targets for the various buildout segments. Provides: - make install - normal dev install with testing and linting tools. - make deploy - bare install only supporting the pyramid app currently. - make lint - run linting tools against the codebase. - make distclean - reset the buildout environment. - make check - clean, install, and run tests. This should be our jenkins/ci target. https://code.launchpad.net/~rharding/charmworld/addbuildout/+merge/138537 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add buildout environment support. #

Patch Set 3 : Add buildout environment support. #

Patch Set 4 : Add buildout environment support. #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+1030 lines, -75 lines) Patch
M .bzrignore View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M Makefile View 1 2 2 chunks +99 lines, -47 lines 1 comment Download
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A bootstrap.py View 1 chunk +262 lines, -0 lines 0 comments Download
A buildout.cfg View 1 chunk +107 lines, -0 lines 4 comments Download
A distribute_setup.py View 1 chunk +485 lines, -0 lines 0 comments Download
M requirements.txt View 1 1 chunk +0 lines, -28 lines 0 comments Download
A versions.cfg View 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 9
rharding
Please take a look.
11 years, 4 months ago (2012-12-06 18:54:47 UTC) #1
rharding
Please take a look.
11 years, 4 months ago (2012-12-06 19:03:11 UTC) #2
rharding
Please take a look.
11 years, 4 months ago (2012-12-06 19:09:00 UTC) #3
abentley-home
On 2012/12/06 19:03:11, rharding wrote: > Please take a look. LGTM with these items addressed: ...
11 years, 4 months ago (2012-12-06 19:10:12 UTC) #4
rharding
*** Submitted: Add buildout environment support. WARNING: not all jobs/scripts and code worked so we ...
11 years, 4 months ago (2012-12-06 19:12:03 UTC) #5
hazmat
https://codereview.appspot.com/6886049/diff/7002/buildout.cfg File buildout.cfg (right): https://codereview.appspot.com/6886049/diff/7002/buildout.cfg#newcode6 buildout.cfg:6: redis this part doesn't exist afaics https://codereview.appspot.com/6886049/diff/7002/buildout.cfg#newcode15 buildout.cfg:15: find-links ...
11 years, 4 months ago (2012-12-06 21:17:25 UTC) #6
hazmat
https://codereview.appspot.com/6886049/diff/7002/buildout.cfg File buildout.cfg (right): https://codereview.appspot.com/6886049/diff/7002/buildout.cfg#newcode3 buildout.cfg:3: develop no part for this either.
11 years, 4 months ago (2012-12-06 21:26:04 UTC) #7
hazmat
https://codereview.appspot.com/6886049/diff/7002/Makefile File Makefile (right): https://codereview.appspot.com/6886049/diff/7002/Makefile#newcode57 Makefile:57: $(NOSE): bin/buildout buildout.cfg versions.cfg setup.py its not clear to ...
11 years, 4 months ago (2012-12-06 21:36:32 UTC) #8
hazmat
11 years, 4 months ago (2012-12-06 21:59:31 UTC) #9
one more.. sorry about doing these individually just finding more as i look.

https://codereview.appspot.com/6886049/diff/7002/buildout.cfg
File buildout.cfg (right):

https://codereview.appspot.com/6886049/diff/7002/buildout.cfg#newcode33
buildout.cfg:33: python-dateutil
these deps should be listed in setup.py, else those aren't accurate/correct, and
given that can be omitted here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b