Issue 6884046: code review 6884046: cmd/8a: support XMM registers.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6884046: code review 6884046: cmd/8a: support XMM registers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by remyoudompheng

Modified:
12 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cmd/8a: support XMM registers.

Patch Set 1 #

Patch Set 2 : diff -r 1f3ebf9a7548 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1f3ebf9a7548 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9735abbe060a https://go.googlecode.com/hg/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+885 lines, -906 lines)			Patch
M	src/cmd/8a/a.y	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/cmd/8a/lex.c	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/cmd/8a/y.tab.h	View	1	6 chunks	+43 lines, -23 lines	0 comments	Download
M	src/cmd/8a/y.tab.c	View	1	100 chunks	+827 lines, -882 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

remyoudompheng

Hello rsc@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 8 months ago (2012-12-05 19:52:49 UTC) #1

remyoudompheng

*** Submitted as https://code.google.com/p/go/source/detail?r=bf0ac83d9ab8 *** cmd/8a: support XMM registers. R=rsc, golang-dev CC=golang-dev https://codereview.appspot.com/6884046

12 years, 8 months ago (2012-12-06 06:27:43 UTC) #2

LGTM

Expand All Messages | Collapse All Messages