code review 68820045: [release-branch.go1.2] runtime: fix crash in runtime.Go...

[release-branch.go1.2] runtime: fix crash in runtime.GoroutineProfile

This CL is not exactly a copy of the original quoted below.
This CL omits the changes made to mgc0.c in the original.
Those changes do not apply cleanly to the Go 1.2 tree,
and they were cosmetic, simplifying code that was already
doing the right thing.

To double-check that omitting the mgc0.c change has not
invalidated the fix, I have verified by hand that the test program
in issue 6946 fails without this CL and passes with this CL.

««« CL 41640043 / e4c381446b48
runtime: fix crash in runtime.GoroutineProfile

This is a possible Go 1.2.1 candidate.

Fixes issue 6946.

R=iant, r
CC=golang-dev
https://codereview.appspot.com/41640043
»»»

[rsc, 2014-02-28 03:50:42]

Hello adg (cc: golang-dev@googlegroups.com, iant, r),

I'd like you to review this change to
https://code.google.com/p/go

[gobot, 2014-02-28 03:52:56]

Replacing golang-dev with golang-codereviews.

To the author of this CL: 

If you are using 'hg mail -r golang-dev' to mail the CL, use simply 'hg mail'
instead.

If you did not name golang-dev explicitly and it was still added to the CL,
it means your working copy of the repo has a stale codereview.cfg
(or lib/codereview/codereview.cfg).
Please run 'hg sync' to update your client to the most recent codereview.cfg.
If the most recent codereview.cfg has defaultcc set to golang-dev instead of
golang-codereviews, please send a CL correcting it.

Thanks very much.

[adg, 2014-02-28 20:40:09]

LGTM

[rsc, 2014-02-28 22:14:04]

*** Submitted as https://code.google.com/p/go/source/detail?r=7ada9e760ce3 ***

[release-branch.go1.2] runtime: fix crash in runtime.GoroutineProfile

This CL is not exactly a copy of the original quoted below.
This CL omits the changes made to mgc0.c in the original.
Those changes do not apply cleanly to the Go 1.2 tree,
and they were cosmetic, simplifying code that was already
doing the right thing.

To double-check that omitting the mgc0.c change has not
invalidated the fix, I have verified by hand that the test program
in issue 6946 fails without this CL and passes with this CL.

««« CL 41640043 / e4c381446b48
runtime: fix crash in runtime.GoroutineProfile

This is a possible Go 1.2.1 candidate.

Fixes issue 6946.

R=iant, r
CC=golang-dev
https://codereview.appspot.com/41640043
»»»

LGTM=adg
R=adg
CC=golang-codereviews, golang-dev, iant, r
https://codereview.appspot.com/68820045

[gobot, 2014-02-28 22:15:59]

This CL appears to have broken the plan9-386-cnielsen builder.