code review 68780043: go/misc/makerelease: pin go-tour repo to a specific revision

go/misc/makerelease: pin go-tour repo to a specific revision

We're about to commit some wide-sweeping changes to the go-tour and I
would rather not include them in Go 1.2.1, which is due in the next
week or so.

Also fix the makerelease tool; it has been broken since it was
renamed from bindist.

[adg, 2014-02-25 21:58:50]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[ioe, 2014-02-25 22:24:34]

Just a nit about using branches instead of hash values.

https://codereview.appspot.com/68780043/diff/1/misc/makerelease/makerelease.go
File misc/makerelease/makerelease.go (right):

https://codereview.appspot.com/68780043/diff/1/misc/makerelease/makerelease.g...
misc/makerelease/makerelease.go:54: defaultTourTag = "bfb239965508" // before
integration of new tour
Why not simply use a branch tag here? That would keep it readable.

[adg, 2014-02-25 22:52:44]

PTAL - also fixed a bug that crept in when renaming the tool.

https://codereview.appspot.com/68780043/diff/1/misc/makerelease/makerelease.go
File misc/makerelease/makerelease.go (right):

https://codereview.appspot.com/68780043/diff/1/misc/makerelease/makerelease.g...
misc/makerelease/makerelease.go:54: defaultTourTag = "bfb239965508" // before
integration of new tour
On 2014/02/25 22:24:34, ioe wrote:
> Why not simply use a branch tag here? That would keep it readable.

Done.

[adg, 2014-02-26 00:09:18]

R=campoy

[francesc, 2014-02-27 20:35:57]

On 2014/02/26 00:09:18, adg wrote:
> R=campoy

LGTM

[adg, 2014-02-28 00:09:32]

*** Submitted as https://code.google.com/p/go/source/detail?r=a76e852f7735 ***

go/misc/makerelease: pin go-tour repo to a specific revision

We're about to commit some wide-sweeping changes to the go-tour and I
would rather not include them in Go 1.2.1, which is due in the next
week or so.

Also fix the makerelease tool; it has been broken since it was
renamed from bindist.

LGTM=campoy
R=campoy
CC=golang-codereviews
https://codereview.appspot.com/68780043

[gobot, 2014-02-28 01:19:31]

This CL appears to have broken the darwin-amd64-race-cheney builder.