code review 68770044: net: clean the dregs of NaCL merge

net: clean the dregs of NaCL merge

[mikio, 2014-02-26 01:00:12]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-02-26 01:04:31]

LGTM

On Tue, Feb 25, 2014 at 5:00 PM,  <mikioh.mikioh@gmail.com> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com (cc:
> golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> net: clean the dregs of NaCL merge
>
> Please review this at https://codereview.appspot.com/68770044/
>
> Affected files (+2, -3 lines):
>   M src/pkg/net/file_test.go
>   M src/pkg/net/file_unix.go
>   M src/pkg/net/ipraw_test.go
>
>
> Index: src/pkg/net/file_test.go
> ===================================================================
> --- a/src/pkg/net/file_test.go
> +++ b/src/pkg/net/file_test.go
> @@ -181,7 +181,7 @@
>
>  func TestFilePacketConn(t *testing.T) {
>         switch runtime.GOOS {
> -       case "plan9", "windows", "nacl":
> +       case "nacl", "plan9", "windows":
>                 t.Skipf("skipping test on %q", runtime.GOOS)
>         }
>
> Index: src/pkg/net/file_unix.go
> ===================================================================
> --- a/src/pkg/net/file_unix.go
> +++ b/src/pkg/net/file_unix.go
> @@ -24,7 +24,6 @@
>
>         sotype, err := syscall.GetsockoptInt(fd, syscall.SOL_SOCKET,
> syscall.SO_TYPE)
>         if err != nil {
> -               println("getsockopt failed", fd, err.Error())
>                 closesocket(fd)
>                 return nil, os.NewSyscallError("getsockopt", err)
>         }
> Index: src/pkg/net/ipraw_test.go
> ===================================================================
> --- a/src/pkg/net/ipraw_test.go
> +++ b/src/pkg/net/ipraw_test.go
> @@ -247,7 +247,7 @@
>
>  func TestIPConnLocalName(t *testing.T) {
>         switch runtime.GOOS {
> -       case "plan9", "windows", "nacl":
> +       case "nacl", "plan9", "windows":
>                 t.Skipf("skipping test on %q", runtime.GOOS)
>         default:
>                 if os.Getuid() != 0 {
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[aram, 2014-02-26 01:07:41]

LGTM

[dave_cheney.net, 2014-02-26 01:09:09]

LGTM. Thanks


On Wed, Feb 26, 2014 at 12:07 PM, <aram@mgk.ro> wrote:

> LGTM
>
> https://codereview.appspot.com/68770044/
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[mikio, 2014-02-26 01:20:55]

*** Submitted as https://code.google.com/p/go/source/detail?r=9bedc3857e8d ***

net: clean the dregs of NaCL merge

LGTM=iant, aram, dave
R=golang-codereviews, iant, aram, dave
CC=golang-codereviews
https://codereview.appspot.com/68770044