Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(187)

Issue 6875063: code review 6875063: runtime: display go version and operating system inform... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by dfc
Modified:
9 years, 7 months ago
CC:
golang-dev
Visibility:
Public.

Description

runtime: display go version and operating system information in panic message Fixes issue 4492. panic: runtime error: invalid memory address or nil pointer dereference [signal 0xb code=0x1 addr=0x0 pc=0x400c03] runtime version: devel +a32219a715c5 Wed Dec 05 15:26:18 2012 +1100 runtime host: linux/amd64 goroutine 1 [running]: main.main() /home/dfc/src/panic.go:3 +0x3 goroutine 2 [syscall]: created by runtime.main /home/dfc/go/src/pkg/runtime/proc.c:225 exit status 2

Patch Set 1 #

Patch Set 2 : diff -r a32219a715c5 https://code.google.com/p/go #

Patch Set 3 : diff -r 5eac1a2d6fc3 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r a32219a715c5 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/pkg/runtime/extern.go View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/panic.c View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 7 months ago (2012-12-05 21:02:29 UTC) #1
dfc
On 2012/12/05 21:02:29, dfc wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
9 years, 7 months ago (2012-12-05 22:19:16 UTC) #2
remyoudompheng
https://codereview.appspot.com/6875063/diff/9001/src/pkg/runtime/extern.go File src/pkg/runtime/extern.go (right): https://codereview.appspot.com/6875063/diff/9001/src/pkg/runtime/extern.go#newcode144 src/pkg/runtime/extern.go:144: var panicvers = "Go runtime version: " + theVersion ...
9 years, 7 months ago (2012-12-05 22:32:20 UTC) #3
dfc
Hello golang-dev@googlegroups.com, remyoudompheng@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 7 months ago (2012-12-05 22:53:33 UTC) #4
dfc
On 2012/12/05 22:53:33, dfc wrote: > Hello mailto:golang-dev@googlegroups.com, mailto:remyoudompheng@gmail.com (cc: > mailto:golang-dev@googlegroups.com), > > I'd ...
9 years, 7 months ago (2012-12-05 22:55:20 UTC) #5
dfc
*** Abandoned ***
9 years, 7 months ago (2012-12-06 04:12:36 UTC) #6
dfc
Good point, it is easy to see the path from the current panic message to ...
9 years, 7 months ago (2012-12-06 06:21:39 UTC) #7
dfc
Please consider the output format to be a suggestion only. For me the idea of ...
9 years, 7 months ago (2012-12-06 06:34:18 UTC) #8
bradfitz
Love the idea. On Dec 5, 2012 1:02 PM, <dave@cheney.net> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
9 years, 7 months ago (2012-12-06 06:34:58 UTC) #9
rsc
This is a very slippery slope. Once you start printing a little bit about the ...
9 years, 7 months ago (2012-12-06 06:43:24 UTC) #10
remyoudompheng
ON 2012/12/5 Dave Cheney <dave@cheney.net> wrote: >> theVersion + " " + GOOS + "/" ...
9 years, 7 months ago (2012-12-06 06:43:45 UTC) #11
dfc
> theVersion + " " + GOOS + "/" + GOARCH + "\n" > I ...
9 years, 7 months ago (2012-12-06 06:45:01 UTC) #12
remyoudompheng
9 years, 7 months ago (2012-12-06 07:06:13 UTC) #13
It's interesting but it looks really weird to me.

Rémy.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b