Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1082)

Issue 6875060: code review 6875060: net/http: fix bug parsing http_proxy lacking a protocol (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by bradfitz
Modified:
9 years, 1 month ago
Reviewers:
rsc
CC:
golang-dev
Visibility:
Public.

Description

net/http: fix bug parsing http_proxy lacking a protocol Per the curl man page, the http_proxy configuration can be of the form: [protocol://]<host>[:port] And we had a test that <ip>:<port> worked, but if the host began with a letter, url.Parse parsed the hostname as the scheme instead, confusing ProxyFromEnvironment.

Patch Set 1 #

Patch Set 2 : diff -r daabe25e67fe https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r daabe25e67fe https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f7c125983d99 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/pkg/net/http/transport.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/http/transport_test.go View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 1 month ago (2012-12-04 20:57:30 UTC) #1
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=9a1367cfa93a *** net/http: fix bug parsing http_proxy lacking a protocol Per the ...
9 years, 1 month ago (2012-12-06 03:08:49 UTC) #2
rsc
9 years, 1 month ago (2012-12-06 06:22:52 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b