Issue 68750043: code review 68750043: 5g, 8g: remove dead code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 68750043: code review 68750043: 5g, 8g: remove dead code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by josharian

Modified:
11 years, 3 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

5g, 8g: remove dead code maxstksize is superfluous and appears to be vestigial. 6g does not use it. c >= 4 cannot occur; c = w % 4.

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -15 lines)			Patch
M	src/cmd/5g/gg.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/5g/ggen.c	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/cmd/8g/gg.h	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/8g/ggen.c	View	1	2 chunks	+1 line, -9 lines	0 comments	Download

Total messages: 4

josharian

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2014-02-25 21:19:20 UTC) #1

josharian

*** Submitted as https://code.google.com/p/go/source/detail?r=dfefccbd6c78 *** 5g, 8g: remove dead code maxstksize is superfluous and appears ...

11 years, 4 months ago (2014-02-25 22:43:57 UTC) #3

gobot

11 years, 3 months ago (2014-02-27 09:34:34 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the linux-arm-cheney-panda builder.