Issue 6873069: code review 6873069: net: make TestDialTimeoutFDLeak a bit robust

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6873069: code review 6873069: net: make TestDialTimeoutFDLeak a bit robust (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by mikio

Modified:
12 years, 3 months ago

Reviewers:

CC:
albert.strasheim, dave_cheney.net, rsc, golang-dev

Visibility:
Public.

Description

net: make TestDialTimeoutFDLeak a bit robust TestDialTimeoutFDLeak will fail when system state somaxconn is greater than expected fixed value. Fixes issue 4384 (again).

Patch Set 1 #

Patch Set 2 : diff -r ec3ae5b98922 https://code.google.com/p/go #

Patch Set 3 : diff -r ec3ae5b98922 https://code.google.com/p/go #

Patch Set 4 : diff -r 89e5cabaa09a https://code.google.com/p/go #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/net/dial_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mikio

Hello fullung@gmail.com, dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 3 months ago (2012-12-12 07:06:53 UTC) #1

mikio

Hi Albert, Would you mind having a look at this CL? Thanks. On Thu, Dec ...

12 years, 3 months ago (2012-12-13 06:52:35 UTC) #3

mikio

12 years, 3 months ago (2012-12-13 07:21:32 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=3fe40a41018d ***

net: make TestDialTimeoutFDLeak a bit robust

TestDialTimeoutFDLeak will fail when system state somaxconn is
greater than expected fixed value.

Fixes issue 4384 (again).

R=fullung, dave, rsc
CC=golang-dev
https://codereview.appspot.com/6873069

Expand All Messages | Collapse All Messages