code review 6873063: regexp: re-enable TestBadCompile

regexp: re-enable TestBadCompile

The code that was commented out was for the old regexp package.
In the new one the errors and the space of valid regexps are different.

[rsc, 2012-12-11 17:00:46]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-12-11 17:00:54]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-12-11 17:08:21]

LGTM

On Tue, Dec 11, 2012 at 12:00 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> regexp: re-enable TestBadCompile
>
> The code that was commented out was for the old regexp package.
> In the new one the errors and the space of valid regexps are different.
>
> Please review this at
https://codereview.appspot.**com/6873063/<https://codereview.appspot.com/6873...
>
> Affected files:
>   M src/pkg/regexp/all_test.go
>
>
> Index: src/pkg/regexp/all_test.go
> ==============================**==============================**=======
> --- a/src/pkg/regexp/all_test.go
> +++ b/src/pkg/regexp/all_test.go
> @@ -30,53 +30,52 @@
>         `\!\\`,
>  }
>
> -/*
>  type stringError struct {
>         re  string
> -       err error
> +       err string
>  }
>
>  var bad_re = []stringError{
> -       {`*`, ErrBareClosure},
> -       {`+`, ErrBareClosure},
> -       {`?`, ErrBareClosure},
> -       {`(abc`, ErrUnmatchedLpar},
> -       {`abc)`, ErrUnmatchedRpar},
> -       {`x[a-z`, ErrUnmatchedLbkt},
> -       {`abc]`, ErrUnmatchedRbkt},
> -       {`[z-a]`, ErrBadRange},
> -       {`abc\`, ErrExtraneousBackslash},
> -       {`a**`, ErrBadClosure},
> -       {`a*+`, ErrBadClosure},
> -       {`a??`, ErrBadClosure},
> -       {`\x`, ErrBadBackslash},
> +       {`*`, "missing argument to repetition operator: `*`"},
> +       {`+`, "missing argument to repetition operator: `+`"},
> +       {`?`, "missing argument to repetition operator: `?`"},
> +       {`(abc`, "missing closing ): `(abc`"},
> +       {`abc)`, "unexpected ): `abc)`"},
> +       {`x[a-z`, "missing closing ]: `[a-z`"},
> +       {`[z-a]`, "invalid character class range: `z-a`"},
> +       {`abc\`, "trailing backslash at end of expression"},
> +       {`a**`, "invalid nested repetition operator: `**`"},
> +       {`a*+`, "invalid nested repetition operator: `*+`"},
> +       {`\x`, "invalid escape sequence: `\\x`"},
>  }
> -*/
>
> -func compileTest(t *testing.T, expr string, error error) *Regexp {
> +func compileTest(t *testing.T, expr string, error string) *Regexp {
>         re, err := Compile(expr)
> -       if err != error {
> +       if error == "" && err != nil {
>                 t.Error("compiling `", expr, "`; unexpected error: ",
> err.Error())
>         }
> +       if error != "" && err == nil {
> +               t.Error("compiling `", expr, "`; missing error")
> +       } else if error != "" && !strings.Contains(err.Error(), error) {
> +               t.Error("compiling `", expr, "`; wrong error: ",
> err.Error(), "; want ", error)
> +       }
>         return re
>  }
>
>  func TestGoodCompile(t *testing.T) {
>         for i := 0; i < len(good_re); i++ {
> -               compileTest(t, good_re[i], nil)
> +               compileTest(t, good_re[i], "")
>         }
>  }
>
> -/*
>  func TestBadCompile(t *testing.T) {
>         for i := 0; i < len(bad_re); i++ {
>                 compileTest(t, bad_re[i].re, bad_re[i].err)
>         }
>  }
> -*/
>
>  func matchTest(t *testing.T, test *FindTest) {
> -       re := compileTest(t, test.pat, nil)
> +       re := compileTest(t, test.pat, "")
>         if re == nil {
>                 return
>         }
>
>
>

[rsc, 2012-12-11 17:19:42]

*** Submitted as https://code.google.com/p/go/source/detail?r=3a97cf1c51ba ***

regexp: re-enable TestBadCompile

The code that was commented out was for the old regexp package.
In the new one the errors and the space of valid regexps are different.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/6873063