Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(793)

Issue 6873060: code review 6873060: go.crypto/ssh: Add support for ECDSA keys and certs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by jmpittman
Modified:
9 years, 1 month ago
Reviewers:
CC:
agl1, dfc, golang-dev
Visibility:
Public.

Description

go.crypto/ssh: Add support for ECDSA keys and certs.

Patch Set 1 #

Patch Set 2 : diff -r 06723ccb4c19 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 06723ccb4c19 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 06723ccb4c19 https://code.google.com/p/go.crypto #

Total comments: 2

Patch Set 5 : diff -r 06723ccb4c19 https://code.google.com/p/go.crypto #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -24 lines) Patch
M ssh/certs.go View 1 2 3 4 4 chunks +21 lines, -9 lines 2 comments Download
M ssh/common.go View 1 4 chunks +21 lines, -3 lines 0 comments Download
M ssh/keys.go View 1 2 3 6 chunks +96 lines, -12 lines 4 comments Download

Messages

Total messages: 13
jmpittman
Hello agl@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
9 years, 1 month ago (2012-12-11 01:12:00 UTC) #1
jmpittman
Hello agl@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 1 month ago (2012-12-11 01:16:03 UTC) #2
jmpittman
Hello agl@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 1 month ago (2012-12-11 14:33:24 UTC) #3
agl1
LGTM. I'll wait a bit to see whether dfc has anything to note. If I ...
9 years, 1 month ago (2012-12-11 15:32:16 UTC) #4
jmpittman
Hello agl@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 1 month ago (2012-12-11 15:52:02 UTC) #5
jmpittman
Thanks for the quick response. I think I covered most everything with the last two ...
9 years, 1 month ago (2012-12-11 15:52:07 UTC) #6
dfc
Sorry I haven't contributed much in the way of reviewing ssh patches, this is very ...
9 years, 1 month ago (2012-12-11 21:52:00 UTC) #7
dfc
LGTM, very nice, thank you. A few minor comments if you feel like addressing them ...
9 years, 1 month ago (2012-12-13 11:16:03 UTC) #8
jmpittman
https://codereview.appspot.com/6873060/diff/12001/ssh/certs.go File ssh/certs.go (right): https://codereview.appspot.com/6873060/diff/12001/ssh/certs.go#newcode47 ssh/certs.go:47: // and ecdsa-sha2-nistp521-cert-v01@openssh.com. On 2012/12/13 11:16:03, dfc wrote: > ...
9 years, 1 month ago (2012-12-13 18:38:49 UTC) #9
dfc
On 14 Dec 2012 05:38, <jmpittman@google.com> wrote: > > > https://codereview.appspot.com/6873060/diff/12001/ssh/certs.go > File ssh/certs.go (right): ...
9 years, 1 month ago (2012-12-13 18:45:11 UTC) #10
jmpittman
On 2012/12/13 18:45:11, dfc wrote: > On 14 Dec 2012 05:38, <mailto:jmpittman@google.com> wrote: > > ...
9 years, 1 month ago (2012-12-13 18:46:23 UTC) #11
dfc
*** Submitted as https://code.google.com/p/go/source/detail?r=a5fe000a4ea3&repo=crypto *** go.crypto/ssh: Add support for ECDSA keys and certs. R=agl, dave ...
9 years, 1 month ago (2012-12-13 18:52:35 UTC) #12
jmpittman
9 years, 1 month ago (2012-12-13 21:56:44 UTC) #13
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b