Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(636)

Issue 6873055: Makefile tweaks

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by bac
Modified:
11 years, 3 months ago
Reviewers:
mp+137991
Visibility:
Public.

Description

Makefile tweaks Bug 1078723 addressed problems with changes to third party JS not forcing a remake of the combined JS files. We really only have one such file now, the others are handled properly, so this branch adds a dependency on it, creates a THIRD_PARTY_JS symbol in the Makefile to make it obvious in the future, and does other clean-up. I tried removing the special-case for bin/generateTemplates (which *is* a JavaScript file) by adding a .js extension. That made most of the make process work but then the linters blew up. I hastily retreated. https://code.launchpad.net/~bac/juju-gui/1078723/+merge/137991 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Makefile tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M Makefile View 1 3 chunks +19 lines, -2 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M bin/merge-files View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
bac
Please take a look.
11 years, 3 months ago (2012-12-04 20:52:47 UTC) #1
benji
Looks good. https://codereview.appspot.com/6873055/diff/1/Makefile File Makefile (right): https://codereview.appspot.com/6873055/diff/1/Makefile#newcode15 Makefile:15: -e '^server.js$$') Yay! Death to long lines. ...
11 years, 3 months ago (2012-12-04 21:09:25 UTC) #2
frankban
Approved. These changes look good Brad, thanks.
11 years, 3 months ago (2012-12-05 11:46:22 UTC) #3
bac
11 years, 3 months ago (2012-12-05 13:07:32 UTC) #4
*** Submitted:

Makefile tweaks

Bug 1078723 addressed problems with changes to third party JS not
forcing a remake of the combined JS files.  We really only have one
such file now, the others are handled properly, so this branch adds a
dependency on it, creates a THIRD_PARTY_JS symbol in the Makefile to
make it obvious in the future, and does other clean-up.

I tried removing the special-case for bin/generateTemplates (which
*is* a JavaScript file) by adding a .js extension.  That made most of
the make process work but then the linters blew up.  I hastily
retreated.

R=benji, frankban
CC=
https://codereview.appspot.com/6873055

https://codereview.appspot.com/6873055/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/6873055/diff/1/Makefile#newcode40
Makefile:40: echo $(JSFILES)
gah!
gone.
done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b