Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(785)

Issue 6873046: code review 6873046: net: change windows netFD finalizer to behave similar t... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by brainman
Modified:
9 years, 6 months ago
Reviewers:
dfc
CC:
mikio, golang-dev
Visibility:
Public.

Description

net: change windows netFD finalizer to behave similar to unix

Patch Set 1 #

Patch Set 2 : diff -r d05272f402ec https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 64847a27cdd5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 1c823043ffc5 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/pkg/net/fd_windows.go View 1 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9
dfc
LGTM. Thanks.
9 years, 7 months ago (2012-12-03 01:38:47 UTC) #1
brainman
Hello dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 6 months ago (2012-12-04 23:15:20 UTC) #2
dfc
On 2012/12/04 23:15:20, brainman wrote: > Hello mailto:dave@cheney.net (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
9 years, 6 months ago (2012-12-05 03:58:08 UTC) #3
brainman
On 2012/12/05 03:58:08, dfc wrote: > > Gentle ping. I'd like to see this CL ...
9 years, 6 months ago (2012-12-05 04:00:59 UTC) #4
dfc
On 2012/12/05 04:00:59, brainman wrote: > On 2012/12/05 03:58:08, dfc wrote: > > > > ...
9 years, 6 months ago (2012-12-05 04:01:48 UTC) #5
brainman
On 2012/12/05 04:01:48, dfc wrote: > > ... I'd like to see yours go first ...
9 years, 6 months ago (2012-12-05 04:04:13 UTC) #6
mikio
LGTM
9 years, 6 months ago (2012-12-05 04:19:52 UTC) #7
brainman
*** Submitted as https://code.google.com/p/go/source/detail?r=a32219a715c5 *** net: change windows netFD finalizer to behave similar to unix ...
9 years, 6 months ago (2012-12-05 04:26:25 UTC) #8
dfc
9 years, 6 months ago (2012-12-06 07:02:33 UTC) #9
This is working great. I haven't seen the windows builders this stable in a long
time.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b