code review 6873046: net: change windows netFD finalizer to behave similar t...

net: change windows netFD finalizer to behave similar to unix

[dave_cheney.net, 2012-12-03 01:38:47]

LGTM. Thanks.

[brainman, 2012-12-04 23:15:20]

Hello dave@cheney.net (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dave_cheney.net, 2012-12-05 03:58:08]

On 2012/12/04 23:15:20, brainman wrote:
> Hello mailto:dave@cheney.net (cc: mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

Gentle ping. I'd like to see this CL reviewed and submitted before landing
https://codereview.appspot.com/6866050/

[brainman, 2012-12-05 04:00:59]

On 2012/12/05 03:58:08, dfc wrote:
> 
> Gentle ping. I'd like to see this CL reviewed and submitted before landing
> https://codereview.appspot.com/6866050/

I am going to wait for mikio. You go ahead and submit yours.

Alex

[dave_cheney.net, 2012-12-05 04:01:48]

On 2012/12/05 04:00:59, brainman wrote:
> On 2012/12/05 03:58:08, dfc wrote:
> > 
> > Gentle ping. I'd like to see this CL reviewed and submitted before landing
> > https://codereview.appspot.com/6866050/
> 
> I am going to wait for mikio. You go ahead and submit yours.
> 
> Alex

I'm also waiting on Mikio :) I'd like to see yours go first because it attempts
to fix the current breakage.

[brainman, 2012-12-05 04:04:13]

On 2012/12/05 04:01:48, dfc wrote:
> 
> ... I'd like to see yours go first because it attempts
> to fix the current breakage.

I hope my change will fix current breakage, but I do not know if it will. I
can't reproduce the breakage here.

Alex

[mikio, 2012-12-05 04:19:52]

LGTM

[brainman, 2012-12-05 04:26:25]

*** Submitted as https://code.google.com/p/go/source/detail?r=a32219a715c5 ***

net: change windows netFD finalizer to behave similar to unix

R=dave, mikioh.mikioh
CC=golang-dev
https://codereview.appspot.com/6873046

[dave_cheney.net, 2012-12-06 07:02:33]

This is working great. I haven't seen the windows builders this stable in a long
time.