Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(524)

Issue 6872050: Fix nova RunServer to return details (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 4 months ago by wallyworld
Modified:
8 years, 4 months ago
Reviewers:
mp+137486
Visibility:
Public.

Description

Fix nova RunServer to return details The RunServer API was not returning the details of the server just started. This branch fixes that. It also updates the nova tests to no longer rely on a specific server instance to be running. Instead, the test suite uses RunServer to create an instance for the tests, and deletes the instance afterwards. This plus a couple of other tweaks make all but 3 of the nova tests pass. 2 of the remaining 3 are the well known floating IP failures, and the other is a security tets failure. These can be addressed in another branch. The work in this branch is needed by the OpenStack provider in juju-core. https://code.launchpad.net/~wallyworld/goose/fix-nova-RunServer/+merge/137486 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix nova RunServer to return details #

Patch Set 3 : Fix nova RunServer to return details #

Patch Set 4 : Fix nova RunServer to return details #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -73 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M nova/nova.go View 1 2 chunks +9 lines, -3 lines 0 comments Download
M nova/nova_test.go View 1 2 14 chunks +105 lines, -70 lines 0 comments Download

Messages

Total messages: 7
wallyworld
Please take a look.
8 years, 4 months ago (2012-12-03 06:33:47 UTC) #1
gz
Looks good, a couple of minor style things, also I'd ditch AdminPass for now as ...
8 years, 4 months ago (2012-12-03 12:24:35 UTC) #2
wallyworld
Please take a look. https://codereview.appspot.com/6872050/diff/1/nova/nova.go File nova/nova.go (right): https://codereview.appspot.com/6872050/diff/1/nova/nova.go#newcode44 nova/nova.go:44: AdminPass string On 2012/12/03 12:24:35, ...
8 years, 4 months ago (2012-12-03 23:53:55 UTC) #3
gz
Looks ready to land. On 2012/12/03 23:53:55, wallyworld wrote: > > Flavor Id is defined ...
8 years, 4 months ago (2012-12-04 11:08:26 UTC) #4
jameinel
LGTM
8 years, 4 months ago (2012-12-04 13:04:30 UTC) #5
wallyworld
Please take a look.
8 years, 4 months ago (2012-12-05 00:01:55 UTC) #6
wallyworld
8 years, 4 months ago (2012-12-05 00:04:23 UTC) #7
*** Submitted:

Fix nova RunServer to return details

The RunServer API was not returning the details of the server just started. This
branch fixes that.
It also updates the nova tests to no longer rely on a specific server instance
to be running. Instead, the
test suite uses RunServer to create an instance for the tests, and deletes the
instance afterwards. This plus a couple
of other tweaks make all but 3 of the nova tests pass. 2 of the remaining 3 are
the well known floating IP failures,
and the other is a security tets failure. These can be addressed in another
branch.

The work in this branch is needed by the OpenStack provider in juju-core.

R=gz, jameinel
CC=
https://codereview.appspot.com/6872050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b