Fix nova RunServer to return details

Fix nova RunServer to return details

The RunServer API was not returning the details of the server just started. This branch fixes that.
It also updates the nova tests to no longer rely on a specific server instance to be running. Instead, the
test suite uses RunServer to create an instance for the tests, and deletes the instance afterwards. This plus a couple
of other tweaks make all but 3 of the nova tests pass. 2 of the remaining 3 are the well known floating IP failures,
and the other is a security tets failure. These can be addressed in another branch.

The work in this branch is needed by the OpenStack provider in juju-core.

https://code.launchpad.net/~wallyworld/goose/fix-nova-RunServer/+merge/137486

(do not edit description out of merge proposal)

[wallyworld, 2012-12-03 06:33:47]

Please take a look.

[gz, 2012-12-03 12:24:35]

Looks good, a couple of minor style things, also I'd ditch AdminPass for now as
it's not being used.

https://codereview.appspot.com/6872050/diff/1/nova/nova.go
File nova/nova.go (right):

https://codereview.appspot.com/6872050/diff/1/nova/nova.go#newcode44
nova/nova.go:44: AdminPass string
As I understand this code, Entity is intended to be a generic type that many
nova objects will provide a superset of information. Now, this may not be the
most sane way of doing things, but AdminPass is certainly server specific so
should not appear here.

https://codereview.appspot.com/6872050/diff/1/nova/nova_test.go
File nova/nova_test.go (right):

https://codereview.appspot.com/6872050/diff/1/nova/nova_test.go#newcode101
nova/nova_test.go:101: c.Assert(sr.Name, Equals, "nova_test_server")
Good change.

https://codereview.appspot.com/6872050/diff/1/nova/nova_test.go#newcode133
nova/nova_test.go:133: c.Assert(sr.Image.Id, Equals,
"0f602ea9-c09e-440c-9e29-cfae5635afa3")
I'd stick this image id in the a file level constant at least, so it's only
appearing once. Probably the flavor id as well.

Comparing the flavor id to string may bork on some deployments.

https://codereview.appspot.com/6872050/diff/1/nova/nova_test.go#newcode241
nova/nova_test.go:241: c.Assert(server.Image.Id, Equals,
"0f602ea9-c09e-440c-9e29-cfae5635afa3")
If reasserting this, move inside a helper?

[wallyworld, 2012-12-03 23:53:55]

Please take a look.

https://codereview.appspot.com/6872050/diff/1/nova/nova.go
File nova/nova.go (right):

https://codereview.appspot.com/6872050/diff/1/nova/nova.go#newcode44
nova/nova.go:44: AdminPass string
On 2012/12/03 12:24:35, gz wrote:
> As I understand this code, Entity is intended to be a generic type that many
> nova objects will provide a superset of information. Now, this may not be the
> most sane way of doing things, but AdminPass is certainly server specific so
> should not appear here.

Ok, will remove from this branch and we can introduce a more specific type later
as and when required.

https://codereview.appspot.com/6872050/diff/1/nova/nova_test.go
File nova/nova_test.go (right):

https://codereview.appspot.com/6872050/diff/1/nova/nova_test.go#newcode133
nova/nova_test.go:133: c.Assert(sr.Image.Id, Equals,
"0f602ea9-c09e-440c-9e29-cfae5635afa3")
On 2012/12/03 12:24:35, gz wrote:
> I'd stick this image id in the a file level constant at least, so it's only
> appearing once. Probably the flavor id as well.
> 

Yeah, I had meant to do that but it slipped my mind. WIll do so.

> Comparing the flavor id to string may bork on some deployments.

Flavor Id is defined as a string though (see the Flavor struct in nova.go)

[gz, 2012-12-04 11:08:26]

Looks ready to land.

On 2012/12/03 23:53:55, wallyworld wrote:
> 
> Flavor Id is defined as a string though (see the Flavor struct in nova.go)

Ah, this might be a case where the struct typing helps us versus just using
dicts in python.

[jameinel, 2012-12-04 13:04:30]

LGTM

[wallyworld, 2012-12-05 00:01:55]

Please take a look.

[wallyworld, 2012-12-05 00:04:23]

*** Submitted:

Fix nova RunServer to return details

The RunServer API was not returning the details of the server just started. This
branch fixes that.
It also updates the nova tests to no longer rely on a specific server instance
to be running. Instead, the
test suite uses RunServer to create an instance for the tests, and deletes the
instance afterwards. This plus a couple
of other tweaks make all but 3 of the nova tests pass. 2 of the remaining 3 are
the well known floating IP failures,
and the other is a security tets failure. These can be addressed in another
branch.

The work in this branch is needed by the OpenStack provider in juju-core.

R=gz, jameinel
CC=
https://codereview.appspot.com/6872050