Doc: cautionary accidentals after a key change (3000)

Doc: cautionary accidentals after a key change (3000)

  Add text and examples to NR 5.4.6 "Using break-visibility"
  to cover the printing of cautionary accidentals following
  an explicit key change.

  (Thanks to Paul Morris for the suggestion)

[Trevor Daniels, 2012-12-02 23:41:28]

Use new \override syntax (no #')

[dak, 2012-12-03 06:00:15]

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/chang...
File Documentation/notation/changing-defaults.itely (right):

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/chang...
Documentation/notation/changing-defaults.itely:3324: \override
Staff.KeyCancellation.break-visibility = #all-invisible
Why not use \omit Staff.KeyCancellation here?  Seems more straightforward for
the all-invisible case.  Is there anything disqualifying its use?

[Keith, 2012-12-03 07:30:36]

Looks nice.
Maybe make it shorter, if you want.

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/chang...
File Documentation/notation/changing-defaults.itely (right):

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/chang...
Documentation/notation/changing-defaults.itely:3301: cautionary accidentals
printed at an explicit key change when
"does not remove the naturals printed at a key change if these naturals are the
only indication of the change:"

I did not recognize the naturals as 'cautionary'.  The clause with "since that"
overwhelmed my English-grammar comprehension.

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/chang...
Documentation/notation/changing-defaults.itely:3318: the visibility of the
@code{KeyCancellation} grob itself:
You might want to combine these two examples into one, with all the text above,
so that the space given to this detail is not so excessive.

I love the second person imperative.  (Please don't change it to "the visibility
can be overridden" just because I pointed it out.)

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/chang...
Documentation/notation/changing-defaults.itely:3324: \override
Staff.KeyCancellation.break-visibility = #all-invisible
On 2012/12/03 06:00:15, dak wrote:
> Why not use \omit Staff.KeyCancellation here?  
All the other examples use 'break-visibility, so it would be puzzling if this
one were done differently.

[dak, 2012-12-03 08:54:27]

On 2012/12/03 07:30:36, Keith wrote:

>
https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/chang...
> Documentation/notation/changing-defaults.itely:3324: \override
> Staff.KeyCancellation.break-visibility = #all-invisible
> On 2012/12/03 06:00:15, dak wrote:
> > Why not use \omit Staff.KeyCancellation here?  
> All the other examples use 'break-visibility, so it would be puzzling if this
> one were done differently.

Ok.  Maybe one should mention somewhere generally that the all-invisible
break-visibility case might often lend itself to using \omit for killing the
stencil instead.

[dak, 2012-12-03 08:56:24]

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/chang...
File Documentation/notation/changing-defaults.itely (right):

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/chang...
Documentation/notation/changing-defaults.itely:3318: the visibility of the
@code{KeyCancellation} grob itself:
On 2012/12/03 07:30:36, Keith wrote:

> I love the second person imperative.  (Please don't change it to "the
visibility
> can be overridden" just because I pointed it out.)

It still would warrant moving "instead" to the end of the sentence.

[Trevor Daniels, 2012-12-04 21:17:45]

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/chang...
File Documentation/notation/changing-defaults.itely (right):

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/chang...
Documentation/notation/changing-defaults.itely:3301: cautionary accidentals
printed at an explicit key change when
On 2012/12/03 07:30:36, Keith wrote:
> "does not remove the naturals printed at a key change if these naturals are
the
> only indication of the change:"
> 
> I did not recognize the naturals as 'cautionary'.  The clause with "since
that"
> overwhelmed my English-grammar comprehension.
I'll simplify it along the lines you suggest.  I think
I'll use "cancelling accidentals printed at a key change",
but I'd like to still mention C major and A minor
explicitly to make sure this rather subtle point is clear.

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/chang...
Documentation/notation/changing-defaults.itely:3318: the visibility of the
@code{KeyCancellation} grob itself:
On 2012/12/03 08:56:25, dak wrote:
> It still would warrant moving "instead" to the end of the sentence.

OK.

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/chang...
Documentation/notation/changing-defaults.itely:3318: the visibility of the
@code{KeyCancellation} grob itself:
On 2012/12/03 07:30:36, Keith wrote:
> You might want to combine these two examples into one, with all the text
above,
> so that the space given to this detail is not so excessive.

I'll try it. 

> I love the second person imperative.  (Please don't change it to "the
visibility
> can be overridden" just because I pointed it out.)

:) OK

[Trevor Daniels, 2012-12-04 22:35:26]

Following Keith and David's comments

[Graham Percival, 2012-12-07 22:32:37]

LGTM

[Trevor Daniels, 2012-12-11 09:19:33]

Pushed to staging as
b22c33711b2190d5fa4bae7be3c85424f6b3135e
Closing