code review 68720043: syscall: fix solaris build

syscall: fix solaris build

Solaris does not define syscall.{Mmap,Munmap}. Move the Mmap test to a new file and exclude solaris as discussed.

[dave_cheney.net, 2014-02-25 20:43:31]

Hello aram@mgk.ro, mikioh.mikioh@gmail.com, iant@golang.org (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[aram, 2014-02-25 20:46:37]

LGTM

https://codereview.appspot.com/68720043/diff/10002/src/pkg/syscall/mmap_unix_...
File src/pkg/syscall/mmap_unix_test.go (right):

https://codereview.appspot.com/68720043/diff/10002/src/pkg/syscall/mmap_unix_...
src/pkg/syscall/mmap_unix_test.go:5: // +build freebsd dragonfly darwin linux
netbsd openbsd
Could you please sort this?

[dave_cheney.net, 2014-02-25 20:51:22]

On 2014/02/25 20:46:37, aram wrote:
> LGTM
> 
>
https://codereview.appspot.com/68720043/diff/10002/src/pkg/syscall/mmap_unix_...
> File src/pkg/syscall/mmap_unix_test.go (right):
> 
>
https://codereview.appspot.com/68720043/diff/10002/src/pkg/syscall/mmap_unix_...
> src/pkg/syscall/mmap_unix_test.go:5: // +build freebsd dragonfly darwin linux
> netbsd openbsd
> Could you please sort this?

Done, sorted both files, PTAL.

[dave_cheney.net, 2014-02-25 20:53:12]

Hello aram@mgk.ro, mikioh.mikioh@gmail.com, iant@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[aram, 2014-02-25 20:55:10]

LGTM

[dave_cheney.net, 2014-02-25 20:56:25]

Thanks. Submitting to fix the build


On Wed, Feb 26, 2014 at 7:55 AM, <aram@mgk.ro> wrote:

> LGTM
>
>
> https://codereview.appspot.com/68720043/
>

[dave_cheney.net, 2014-02-25 20:57:44]

*** Submitted as https://code.google.com/p/go/source/detail?r=3b393bd2c43b ***

syscall: fix solaris build

Solaris does not define syscall.{Mmap,Munmap}. Move the Mmap test to a new file
and exclude solaris as discussed.

LGTM=aram
R=aram, mikioh.mikioh, iant
CC=golang-codereviews
https://codereview.appspot.com/68720043

[gobot, 2014-02-25 21:03:29]

This CL appears to have broken the netbsd-386-minux builder.

[dave_cheney.net, 2014-02-25 21:06:31]

Lies,

--- FAIL: TestOverflowSleep (0.13 seconds)
	sleep_test.go:363: negative timeout didn't fire
FAIL
FAIL	time	5.668s



On Wed, Feb 26, 2014 at 8:03 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the netbsd-386-minux builder.
>
> https://codereview.appspot.com/68720043/
>

[mikio, 2014-02-25 21:53:34]

please use "hg copy" in next time.

[dave_cheney.net, 2014-02-25 22:18:48]

I did, really I did.

On Wednesday, February 26, 2014, Mikio Hara <mikioh.mikioh@gmail.com> wrote:

> please use "hg copy" in next time.
>