Issue 6871058: code review 6871058: gc: avoid meaningless constant overflow error for inver...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6871058: code review 6871058: gc: avoid meaningless constant overflow error for inver... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by iant

Modified:
12 years, 7 months ago

Reviewers:

CC:
golang-dev, DMorsing

Visibility:
Public.

Description

gc: avoid meaningless constant overflow error for inverted slice range Used to say: issue4251.go:12: inverted slice range issue4251.go:12: constant -1 overflows uint64 issue4251.go:16: inverted slice range issue4251.go:16: constant -1 overflows uint64 issue4251.go:20: inverted slice range issue4251.go:20: constant -1 overflows uint64 With this patch, only gives the "inverted slice range" errors.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 9dedd7cd21ed https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5eac1a2d6fc3 https://go.googlecode.com/hg/ #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -10 lines)			Patch
M	src/cmd/gc/typecheck.c	View	1	2 chunks	+22 lines, -6 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
A	test/fixedbugs/issue4251.go	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 7 months ago (2012-12-04 09:03:17 UTC) #1

DMorsing

https://codereview.appspot.com/6871058/diff/1/src/cmd/gc/walk.c File src/cmd/gc/walk.c (right): https://codereview.appspot.com/6871058/diff/1/src/cmd/gc/walk.c#newcode2539 src/cmd/gc/walk.c:2539: if(lbv >= 0 && hbv >= 0 && lbv ...

12 years, 7 months ago (2012-12-04 09:56:18 UTC) #2

iant

PTAL https://codereview.appspot.com/6871058/diff/1/src/cmd/gc/walk.c File src/cmd/gc/walk.c (right): https://codereview.appspot.com/6871058/diff/1/src/cmd/gc/walk.c#newcode2539 src/cmd/gc/walk.c:2539: if(lbv >= 0 && hbv >= 0 && ...

12 years, 7 months ago (2012-12-04 11:41:03 UTC) #3

DMorsing

LGTM. The typechecking of slice operations is getting a bit complex. I'll look into simplifying ...

12 years, 7 months ago (2012-12-04 12:02:50 UTC) #4

iant

12 years, 7 months ago (2012-12-05 23:46:56 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=f7c125983d99 ***

gc: avoid meaningless constant overflow error for inverted slice range

Used to say:

issue4251.go:12: inverted slice range
issue4251.go:12: constant -1 overflows uint64
issue4251.go:16: inverted slice range
issue4251.go:16: constant -1 overflows uint64
issue4251.go:20: inverted slice range
issue4251.go:20: constant -1 overflows uint64

With this patch, only gives the "inverted slice range" errors.

R=golang-dev, daniel.morsing
CC=golang-dev
https://codereview.appspot.com/6871058

Expand All Messages | Collapse All Messages