Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(89)

Issue 6869060: code review 6869060: container/heap: Simplify the example. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by schulze
Modified:
10 years ago
Reviewers:
CC:
golang-dev, gri
Visibility:
Public.

Description

container/heap: Simplify the example. Using append simplifies the code and makes it work if the initial capacity of the slice is smaller than the number of items pushed.

Patch Set 1 #

Patch Set 2 : diff -r daabe25e67fe https://code.google.com/p/go #

Patch Set 3 : diff -r daabe25e67fe https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M src/pkg/container/heap/example_test.go View 1 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 3
schulze
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years ago (2012-12-04 20:45:03 UTC) #1
gri
LGTM thanks.
10 years ago (2012-12-04 21:37:27 UTC) #2
gri
10 years ago (2012-12-04 22:11:36 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=64847a27cdd5 ***

container/heap: Simplify the example.

Using append simplifies the code and makes it work if
the initial capacity of the slice is smaller than the
number of items pushed.

R=golang-dev, gri
CC=golang-dev
https://codereview.appspot.com/6869060

Committer: Robert Griesemer <gri@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b