Issue 6869053: code review 6869053: net/http: populate ContentLength in HEAD responses

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6869053: code review 6869053: net/http: populate ContentLength in HEAD responses (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by bradfitz

Modified:
11 years, 4 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

net/http: populate ContentLength in HEAD responses Also fixes a necessary TODO in the process. Fixes issue 4126

Patch Set 2 : diff -r b7fd6fe38b63 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b7fd6fe38b63 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r bf0ac83d9ab8 https://go.googlecode.com/hg/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -17 lines)			Patch
M	src/pkg/net/http/client_test.go	View	1 2 3	1 chunk	+35 lines, -0 lines	0 comments	Download
M	src/pkg/net/http/response.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/net/http/response_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/http/server.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/http/transfer.go	View	1	5 chunks	+32 lines, -8 lines	0 comments	Download
M	src/pkg/net/http/transport.go	View	1 2 3	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/pkg/net/http/transport_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 4 months ago (2012-12-04 01:05:00 UTC) #1

rsc

LGTM Nice test. https://codereview.appspot.com/6869053/diff/5001/src/pkg/net/http/client_test.go File src/pkg/net/http/client_test.go (right): https://codereview.appspot.com/6869053/diff/5001/src/pkg/net/http/client_test.go#newcode531 src/pkg/net/http/client_test.go:531: // Verify Resposne.ContentLength is populated. http://golang.org/issue/4126 ...

11 years, 4 months ago (2012-12-06 04:54:08 UTC) #2

bradfitz

11 years, 4 months ago (2012-12-06 06:36:26 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=d1f2902e0f0d ***

net/http: populate ContentLength in HEAD responses

Also fixes a necessary TODO in the process.

Fixes issue 4126

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/6869053

Expand All Messages | Collapse All Messages