Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(539)

Issue 6869044: Fix some error handling changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 4 months ago by wallyworld
Modified:
8 years, 4 months ago
Reviewers:
mp+137420
Visibility:
Public.

Description

Fix some error handling changes Some changes to error handling were introduced to try and properly handle the case where failed JSON resulted in an err being returned as expected. But the data structures were left possible partially populated. The previous branch returned nil for this situation but non pointers cannot be set to nil. This branch use pointers for return data types of nova and glance apis so that nil can be returned if there is an error. https://code.launchpad.net/~wallyworld/goose/fix-test-error-checking/+merge/137420 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix some error handling changes #

Patch Set 3 : Fix some error handling changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -53 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M glance/glance.go View 1 2 chunks +10 lines, -4 lines 0 comments Download
M glance/glance_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M nova/nova.go View 12 chunks +55 lines, -22 lines 0 comments Download
M nova/nova_test.go View 13 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 4
wallyworld
Please take a look.
8 years, 4 months ago (2012-12-02 13:33:34 UTC) #1
wallyworld
Please take a look.
8 years, 4 months ago (2012-12-02 13:37:00 UTC) #2
wallyworld
On 2012/12/02 13:33:34, wallyworld wrote: > Please take a look. I'm going to land this ...
8 years, 4 months ago (2012-12-02 13:37:33 UTC) #3
wallyworld
8 years, 4 months ago (2012-12-02 13:39:09 UTC) #4
*** Submitted:

Fix some error handling changes

Some changes to error handling were introduced to try and properly handle the
case where failed JSON resulted in an err being returned as expected. But the
data structures were left possible partially populated.
The previous branch returned nil for this situation but non pointers cannot be
set to nil. 
This branch use pointers for return data types of nova and glance apis so that
nil can be returned if there is an error.

R=
CC=
https://codereview.appspot.com/6869044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b