Issue 6868092: Make tests runnable in production.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6868092: Make tests runnable in production.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by teknico

Modified:
11 years, 5 months ago

Reviewers:
mp+139002

Visibility:
Public.

Description

Make tests runnable in production. Allow tests to run in the production environment, by executing the "make test-prod" command. They currently fail, and will be fixed in a future branch. The branch also sorts the PHONY makefile targets in alphabetical order. https://code.launchpad.net/~teknico/juju-gui/run-tests-in-prod-too/+merge/139002 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Make tests runnable in production. #

Total comments: 2

Patch Set 3 : Make tests runnable in production. #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -13 lines)			Patch
M	Makefile	View	1 2	3 chunks	+18 lines, -8 lines	0 comments	Download
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test-server.js	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	test-server.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gary.poster

Looks good. Land as is (though I have a single small suggestion). Thanks Nicola. Gary ...

11 years, 5 months ago (2012-12-10 17:19:16 UTC) #3

bac

Looks good to land with one suggestion. https://codereview.appspot.com/6868092/diff/2002/Makefile File Makefile (right): https://codereview.appspot.com/6868092/diff/2002/Makefile#newcode392 Makefile:392: undocumented yuidoc ...

11 years, 5 months ago (2012-12-10 17:20:43 UTC) #4

teknico

11 years, 5 months ago (2012-12-10 17:31:25 UTC) #5

*** Submitted:

Make tests runnable in production.

Allow tests to run in the production environment, by executing
the "make test-prod" command. They currently fail, and will be
fixed in a future branch.

The branch also sorts the PHONY makefile targets in alphabetical order.

R=gary.poster, bac
CC=
https://codereview.appspot.com/6868092

Expand All Messages | Collapse All Messages