Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(261)

Issue 6868071: code review 6868071: godoc: move example list into index section (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by rsc
Modified:
12 years, 6 months ago
Reviewers:
CC:
adg, dsymonds, golang-dev
Visibility:
Public.

Description

godoc: move example list into index section Putting it before the Index (where it is now) is wrong: we don't even know what's in the package yet. Fixes issue 4484.

Patch Set 1 #

Patch Set 2 : diff -r 6e0e4077f488 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6e0e4077f488 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c031aa767edf https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M lib/godoc/package.html View 1 3 chunks +12 lines, -17 lines 0 comments Download

Messages

Total messages: 7
rsc
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 7 months ago (2012-12-05 16:39:09 UTC) #1
adg
We changed this a while back to make the examples more discoverable. This restores the ...
12 years, 6 months ago (2012-12-10 04:21:21 UTC) #2
rsc
The new layout makes the list visible always, at the bottom of the index, instead ...
12 years, 6 months ago (2012-12-10 06:44:31 UTC) #3
dsymonds
On Mon, Dec 10, 2012 at 5:44 PM, Russ Cox <rsc@golang.org> wrote: > The new ...
12 years, 6 months ago (2012-12-10 08:25:24 UTC) #4
rsc
> The problem was for big packages (net/http, os, and so on), where the > ...
12 years, 6 months ago (2012-12-10 14:45:17 UTC) #5
adg
LGTM
12 years, 6 months ago (2012-12-11 00:51:17 UTC) #6
rsc
12 years, 6 months ago (2012-12-11 01:20:08 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=7b9e9fc59eb5 ***

godoc: move example list into index section

Putting it before the Index (where it is now) is wrong:
we don't even know what's in the package yet.

Fixes issue 4484.

R=adg, dsymonds
CC=golang-dev
https://codereview.appspot.com/6868071
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b