Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1092)

Issue 6868070: environs/ec2: use default-series on Bootstrap

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by niemeyer
Modified:
9 years, 1 month ago
Reviewers:
mp+138156, fwereade, rog
Visibility:
Public.

Description

environs/ec2: use default-series on Bootstrap https://code.launchpad.net/~niemeyer/juju-core/ec2-bootstrap-default-series/+merge/138156 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 9

Patch Set 2 : environs/ec2: use default-series on Bootstrap #

Total comments: 2

Patch Set 3 : environs/ec2: use default-series on Bootstrap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -3 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M environs/ec2/ec2.go View 1 chunk +3 lines, -1 line 0 comments Download
M environs/jujutest/livetests.go View 1 2 3 chunks +77 lines, -2 lines 0 comments Download

Messages

Total messages: 9
niemeyer
Please take a look.
9 years, 1 month ago (2012-12-05 13:55:14 UTC) #1
rog
another 5 minutes more to run live tests. wouldn't it be nice if we could ...
9 years, 1 month ago (2012-12-05 14:56:23 UTC) #2
niemeyer
https://codereview.appspot.com/6868070/diff/1/environs/jujutest/livetests.go File environs/jujutest/livetests.go (right): https://codereview.appspot.com/6868070/diff/1/environs/jujutest/livetests.go#newcode694 environs/jujutest/livetests.go:694: _, err = environs.PutTools(storage, &other) On 2012/12/05 14:56:23, rog ...
9 years, 1 month ago (2012-12-05 15:48:22 UTC) #3
rog
https://codereview.appspot.com/6868070/diff/1/environs/jujutest/livetests.go File environs/jujutest/livetests.go (right): https://codereview.appspot.com/6868070/diff/1/environs/jujutest/livetests.go#newcode694 environs/jujutest/livetests.go:694: _, err = environs.PutTools(storage, &other) On 2012/12/05 15:48:23, niemeyer ...
9 years, 1 month ago (2012-12-05 16:03:22 UTC) #4
niemeyer
Please take a look.
9 years, 1 month ago (2012-12-12 14:08:16 UTC) #5
rog
On 2012/12/12 14:08:16, niemeyer wrote: > Please take a look. LGTM
9 years, 1 month ago (2012-12-12 14:55:28 UTC) #6
rog
https://codereview.appspot.com/6868070/diff/5001/environs/jujutest/livetests.go File environs/jujutest/livetests.go (right): https://codereview.appspot.com/6868070/diff/5001/environs/jujutest/livetests.go#newcode710 environs/jujutest/livetests.go:710: _, err = environs.PutTools(dummyStorage, &current.Number) nice https://codereview.appspot.com/6868070/diff/5001/environs/jujutest/livetests.go#newcode729 environs/jujutest/livetests.go:729: // ...
9 years, 1 month ago (2012-12-12 14:55:36 UTC) #7
fwereade
LGTM modulo rog's missing "Note that"
9 years, 1 month ago (2012-12-12 15:21:41 UTC) #8
niemeyer
9 years, 1 month ago (2012-12-12 16:52:07 UTC) #9
*** Submitted:

environs/ec2: use default-series on Bootstrap

R=rog, fwereade
CC=
https://codereview.appspot.com/6868070
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b