Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(91)

Issue 6868044: code review 6868044: encoding/xml: namespace handling

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by cjyar
Modified:
2 weeks, 1 day ago
Reviewers:
rsc, dfc, niemeyer, mendel
CC:
golang-codereviews
Visibility:
Public.

Description

encoding/xml: namespace handling
        This is a revised patch for 6856092, issue 3526. This fixes various
        aspects of XML namespace handling, especially attributes in namespaces
        other than their containing elements'.

Patch Set 1 #

Patch Set 2 : diff -r d05272f402ec https://code.google.com/p/go #

Patch Set 3 : diff -r b1822aac85b7 https://code.google.com/p/go #

Patch Set 4 : diff -r b1822aac85b7 https://code.google.com/p/go #

Patch Set 5 : diff -r 0320ad78230f https://code.google.com/p/go #

Patch Set 6 : diff -r 0320ad78230f https://code.google.com/p/go #

Patch Set 7 : code review 6868044: encoding/xml: namespace handling #

Patch Set 8 : diff -r 8ea98ec93704 https://code.google.com/p/go #

Total comments: 2

Patch Set 9 : diff -r 8ea98ec93704 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -61 lines) Patch
src/pkg/encoding/xml/atom_test.go View 7 2 chunks +2 lines, -1 line 0 comments Download
src/pkg/encoding/xml/decodectx_test.go View 1 2 3 4 5 6 7 1 chunk +50 lines, -0 lines 0 comments Download
src/pkg/encoding/xml/marshal.go View 1 2 3 4 5 6 7 8 10 chunks +86 lines, -23 lines 0 comments Download
src/pkg/encoding/xml/marshal_test.go View 1 2 3 4 5 6 7 8 6 chunks +91 lines, -2 lines 0 comments Download
src/pkg/encoding/xml/namespace.go View 1 2 3 4 5 6 7 8 1 chunk +60 lines, -0 lines 0 comments Download
src/pkg/encoding/xml/namespace_test.go View 1 2 3 4 5 6 7 1 chunk +63 lines, -0 lines 0 comments Download
src/pkg/encoding/xml/read.go View 1 2 3 4 5 6 7 8 4 chunks +4 lines, -4 lines 0 comments Download
src/pkg/encoding/xml/read_test.go View 7 2 chunks +2 lines, -0 lines 0 comments Download
src/pkg/encoding/xml/typeinfo.go View 1 2 3 4 5 6 7 13 chunks +49 lines, -21 lines 0 comments Download
src/pkg/encoding/xml/xml.go View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
src/pkg/encoding/xml/xml_test.go View 7 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 20
rsc
Just found this linked in issue 3526. Please run hg mail to send to golang-dev. ...
1 year, 4 months ago #1
chris_cjones.org
maxwell$ hg stat M src/pkg/encoding/xml/atom_test.go M src/pkg/encoding/xml/marshal.go M src/pkg/encoding/xml/marshal_test.go M src/pkg/encoding/xml/read.go M src/pkg/encoding/xml/read_test.go M src/pkg/encoding/xml/typeinfo.go ...
1 year, 4 months ago #2
cjyar
Hello golang-dev@googlegroups.com, rsc@golang.org, chris@cjones.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
1 year, 4 months ago #3
rsc
I'd like to see what Gustavo thinks if he's around. There's a lot of new ...
1 year, 4 months ago #4
cjyar
Hello rsc@golang.org, chris@cjones.org, n13m3y3r@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
1 year, 4 months ago #5
cjyar
Hello rsc@golang.org, chris@cjones.org, n13m3y3r@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
1 year, 4 months ago #6
cjyar
Hello rsc@golang.org, chris@cjones.org, n13m3y3r@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
1 year, 4 months ago #7
cjyar
Hello rsc@golang.org, chris@cjones.org, n13m3y3r@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
1 year, 4 months ago #8
rsc
I would like to drop Context from the API. Can we do that? It seems ...
1 year, 4 months ago #9
rsc
Perhaps, but perhaps not. I think that if you need to send a <foo> in ...
1 year, 4 months ago #10
rsc
It's easy to handle the parsing half. Use the xml Decoder to read the first ...
1 year, 4 months ago #11
cjyar
Hello rsc@golang.org, chris@cjones.org, n13m3y3r@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
1 year, 3 months ago #12
rsc
Can we please split this into two CLs, one for encoding and one for decoding? ...
1 year, 3 months ago #13
cjyar
It would be awkward to split this into two CLs, but I'll do it if ...
1 year, 3 months ago #14
rsc
I believe that Unmarshal is handling name spaces just fine and does not need changes. ...
1 year, 3 months ago #15
cjyar
Hello rsc@golang.org, n13m3y3r@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
1 year, 2 months ago #16
mendel
On 2013/01/31 05:33:44, cjyar wrote: > Hello mailto:rsc@golang.org, mailto:n13m3y3r@gmail.com (cc: mailto:golang-dev@googlegroups.com), > > Please take ...
4 months, 4 weeks ago #17
dfc
@mendel this is not the appropriate forum for a bug report. Please log issues here, ...
4 months, 3 weeks ago #18
gobot
Replacing golang-dev with golang-codereviews.
4 months ago #19
rsc
2 weeks, 1 day ago #20
R=close

The referenced issue is marked fixed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5