Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3842)

Issue 6867080: Add the ability to rebuild the undocumented file.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by benji
Modified:
11 years, 5 months ago
Reviewers:
benjamin.saller, mp+138819
Visibility:
Public.

Description

Add the ability to rebuild the undocumented file. Add an "undocumented" make target that rebuilds the yuidoc linter's list of legacy undocumented functions. https://code.launchpad.net/~benji/juju-gui/yuidoc-forgiveness/+merge/138819 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add the ability to rebuild the undocumented file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -223 lines) Patch
M Makefile View 2 chunks +4 lines, -1 line 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M bin/lint-yuidoc View 1 4 chunks +35 lines, -9 lines 0 comments Download
M undocumented View 1 chunk +240 lines, -213 lines 0 comments Download

Messages

Total messages: 4
benji
Please take a look.
11 years, 5 months ago (2012-12-07 19:22:12 UTC) #1
benjamin.saller
LGTM, there is a minor, but I don't feel strongly. https://codereview.appspot.com/6867080/diff/1/bin/lint-yuidoc File bin/lint-yuidoc (right): https://codereview.appspot.com/6867080/diff/1/bin/lint-yuidoc#newcode114 ...
11 years, 5 months ago (2012-12-07 19:27:58 UTC) #2
benji
Thanks for the feedback. I made the suggested change. https://codereview.appspot.com/6867080/diff/1/bin/lint-yuidoc File bin/lint-yuidoc (right): https://codereview.appspot.com/6867080/diff/1/bin/lint-yuidoc#newcode114 bin/lint-yuidoc:114: ...
11 years, 5 months ago (2012-12-07 19:33:24 UTC) #3
benji
11 years, 5 months ago (2012-12-07 19:35:45 UTC) #4
*** Submitted:

Add the ability to rebuild the undocumented file.

Add an "undocumented" make target that rebuilds the yuidoc linter's list of
legacy undocumented functions.

R=benjamin.saller
CC=
https://codereview.appspot.com/6867080
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b