Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(76)

Issue 6867052: Return slices not pointers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 4 months ago by wallyworld
Modified:
8 years, 4 months ago
Reviewers:
mp+137730
Visibility:
Public.

Description

Return slices not pointers A previous change made all APIs return pointers but this is not necessary when the return type is a slice. This branch fixes that. https://code.launchpad.net/~wallyworld/goose/api-fixes/+merge/137730 Requires: https://code.launchpad.net/~wallyworld/goose/fix-nova-RunServer/+merge/137486 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Return slices not pointers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -28 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M glance/glance.go View 2 chunks +2 lines, -2 lines 0 comments Download
M glance/glance_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M nova/nova.go View 10 chunks +12 lines, -12 lines 0 comments Download
M nova/nova_test.go View 7 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 4
wallyworld
Please take a look.
8 years, 4 months ago (2012-12-04 01:25:02 UTC) #1
dfc
On 2012/12/04 01:25:02, wallyworld wrote: > Please take a look. LGTM. Thank you
8 years, 4 months ago (2012-12-04 05:11:39 UTC) #2
jameinel
LGTM
8 years, 4 months ago (2012-12-04 12:49:18 UTC) #3
wallyworld
8 years, 4 months ago (2012-12-05 00:06:06 UTC) #4
*** Submitted:

Return slices not pointers

A previous change made all APIs return pointers but this is not necessary when
the return type is a slice.
This branch fixes that.

R=dfc, jameinel
CC=
https://codereview.appspot.com/6867052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b