Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 6866053: Add drawPoints dash bench (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by robertphillips
Modified:
11 years, 5 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This is further setup for the 3on/3off optimization. Without "optimization" drawpointsdash_5_5_aa 8888: msecs = 24.43 GPU: msecs = 36.71 drawpointsdash_5_5_bw 8888: msecs = 11.05 GPU: msecs = 14.67 drawpointsdash_3_1_aa 8888: msecs = 15.96 GPU: msecs = 31.00 drawpointsdash_3_1_bw 8888: msecs = 12.85 GPU: msecs = 20.44 drawpointsdash_1_1_aa 8888: msecs = 38.58 GPU: msecs = 61.46 drawpointsdash_1_1_bw 8888: msecs = 34.65 GPU: msecs = 44.79 With "optimization" drawpointsdash_5_5_aa 8888: msecs = 24.86 GPU: msecs = 36.28 drawpointsdash_5_5_bw 8888: msecs = 11.31 GPU: msecs = 14.84 drawpointsdash_3_1_aa 8888: msecs = 16.57 GPU: msecs = 31.26 drawpointsdash_3_1_bw 8888: msecs = 13.32 GPU: msecs = 20.47 drawpointsdash_1_1_aa 8888: msecs = 9.16 GPU: msecs = 161.06 drawpointsdash_1_1_bw 8888: msecs = 3.71 GPU: msecs = 48.80 With "optimization" and memory allocation changes drawpointsdash_5_5_aa 8888: msecs = 25.49 GPU: msecs = 37.12 drawpointsdash_5_5_bw 8888: msecs = 11.73 GPU: msecs = 15.68 drawpointsdash_3_1_aa 8888: msecs = 16.36 GPU: msecs = 30.89 drawpointsdash_3_1_bw 8888: msecs = 13.87 GPU: msecs = 21.37 drawpointsdash_1_1_aa 8888: msecs = 8.70 GPU: msecs = 158.68 drawpointsdash_1_1_bw 8888: msecs = 3.56 GPU: msecs = 50.64 The 5_5 && 3_1 cases don't have a fast path yet so they remain the same - as expected. The 1_1 cases show the expected speedup for raster but a massive slow down for GPU (particularly for AA rects). The use of new[] instead of an SkTDArray for the allocation of the results provides a marginal improvement (at least on Windows) for the raster case.

Patch Set 1 #

Patch Set 2 : Add minor optimizations #

Patch Set 3 : Fixed debug-only error #

Patch Set 4 : Minor fix for returned point count #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -13 lines) Patch
M bench/DashBench.cpp View 1 2 3 4 chunks +66 lines, -1 line 0 comments Download
M include/core/SkPathEffect.h View 1 2 3 2 chunks +8 lines, -3 lines 1 comment Download
M src/core/SkDraw.cpp View 1 2 3 1 chunk +14 lines, -6 lines 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 2 3 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 2
bsalomon
lgtm https://codereview.appspot.com/6866053/diff/7001/include/core/SkPathEffect.h File include/core/SkPathEffect.h (right): https://codereview.appspot.com/6866053/diff/7001/include/core/SkPathEffect.h#newcode168 include/core/SkPathEffect.h:168: SkPoint* fPoints; // the center point of each ...
11 years, 5 months ago (2012-12-05 18:35:35 UTC) #1
robertphillips
11 years, 5 months ago (2012-12-05 19:07:48 UTC) #2
Message was sent while issue was closed.
committed as r6678
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b