Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 6866051: code review 6866051: tiff: support for writing compressed images. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by bsiegert
Modified:
9 years, 3 months ago
Reviewers:
nigeltao
CC:
nigeltao, mikio, golang-dev
Visibility:
Public.

Description

go.image/tiff: support for writing compressed images. Only Deflate compression is supported for now.

Patch Set 1 #

Patch Set 2 : diff -r a0de9da0017e https://code.google.com/p/go.image #

Patch Set 3 : diff -r a0de9da0017e https://code.google.com/p/go.image #

Total comments: 4

Patch Set 4 : diff -r a0de9da0017e https://code.google.com/p/go.image #

Patch Set 5 : diff -r a0de9da0017e https://code.google.com/p/go.image #

Total comments: 2

Patch Set 6 : diff -r a0de9da0017e https://code.google.com/p/go.image #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -20 lines) Patch
M tiff/consts.go View 1 2 3 4 1 chunk +12 lines, -1 line 0 comments Download
M tiff/writer.go View 1 2 3 4 5 2 chunks +46 lines, -19 lines 0 comments Download
M tiff/writer_test.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9
bsiegert
Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.image
9 years, 10 months ago (2012-12-04 13:29:30 UTC) #1
nigeltao
https://codereview.appspot.com/6866051/diff/5001/tiff/consts.go File tiff/consts.go (right): https://codereview.appspot.com/6866051/diff/5001/tiff/consts.go#newcode133 tiff/consts.go:133: for _, v := range compressionEq { I'd just ...
9 years, 10 months ago (2012-12-05 03:34:38 UTC) #2
bsiegert
Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 9 months ago (2012-12-10 15:43:58 UTC) #3
bsiegert
https://codereview.appspot.com/6866051/diff/5001/tiff/consts.go File tiff/consts.go (right): https://codereview.appspot.com/6866051/diff/5001/tiff/consts.go#newcode133 tiff/consts.go:133: for _, v := range compressionEq { On 2012/12/05 ...
9 years, 9 months ago (2012-12-10 15:44:04 UTC) #4
nigeltao
https://codereview.appspot.com/6866051/diff/12001/tiff/writer.go File tiff/writer.go (right): https://codereview.appspot.com/6866051/diff/12001/tiff/writer.go#newcode184 tiff/writer.go:184: compression := Uncompressed It might be better to write ...
9 years, 9 months ago (2012-12-11 00:44:09 UTC) #5
mikio
perhaps the CL description might be "go.image/tiff: ...".
9 years, 9 months ago (2012-12-11 00:48:44 UTC) #6
bsiegert
PTAL. Also changed the CL description as requested. https://codereview.appspot.com/6866051/diff/12001/tiff/writer.go File tiff/writer.go (right): https://codereview.appspot.com/6866051/diff/12001/tiff/writer.go#newcode184 tiff/writer.go:184: compression ...
9 years, 9 months ago (2012-12-11 08:22:51 UTC) #7
nigeltao
LGTM.
9 years, 9 months ago (2012-12-12 02:23:13 UTC) #8
nigeltao
9 years, 9 months ago (2012-12-12 02:24:29 UTC) #9
*** Submitted as
https://code.google.com/p/go/source/detail?r=d16be1f828b0&repo=image ***

go.image/tiff: support for writing compressed images.

Only Deflate compression is supported for now.

R=nigeltao, mikioh.mikioh
CC=golang-dev
https://codereview.appspot.com/6866051

Committer: Nigel Tao <nigeltao@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b