Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2776)

Issue 6866047: code review 6866047: cmd/gc: fix wrong interaction between inlining and embe... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 12 months ago by remyoudompheng
Modified:
9 years, 11 months ago
Reviewers:
CC:
lvd2, rsc, DMorsing, golang-dev
Visibility:
Public.

Description

cmd/gc: fix wrong interaction between inlining and embedded builtins. The patch makes the compile user an ordinary package-local symbol for the name of embedded fields of builtin type. This is incompatible with the fix delivered for issue 2687 (revision 3c060add43fb) but fixes it in a different way, because the explicit symbol on the field makes the typechecker able to find it in lookdot. Fixes issue 3552.

Patch Set 1 #

Patch Set 2 : diff -r 6ec24fe2e501 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6ec24fe2e501 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6ec24fe2e501 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 5 : diff -r 1f3ebf9a7548 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 1f3ebf9a7548 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 1f3ebf9a7548 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 8 : diff -r 1fd839e10187 https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r 4144b7f4d82e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -49 lines) Patch
M src/cmd/gc/dcl.c View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/cmd/gc/fmt.c View 1 2 3 4 5 6 7 2 chunks +1 line, -10 lines 0 comments Download
M test/fixedbugs/issue3552.go View 1 2 3 4 5 6 7 1 chunk +4 lines, -4 lines 0 comments Download
M test/fixedbugs/issue3552.dir/one.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/fixedbugs/issue3552.dir/two.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/run.go View 1 2 3 4 5 6 3 chunks +36 lines, -37 lines 0 comments Download

Messages

Total messages: 12
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 12 months ago (2012-12-03 16:53:25 UTC) #1
lvd2
LGTM
9 years, 12 months ago (2012-12-03 17:51:19 UTC) #2
remyoudompheng
Hello golang-dev@googlegroups.com, lvd@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 12 months ago (2012-12-03 19:14:30 UTC) #3
remyoudompheng
https://codereview.appspot.com/6866047/diff/3/test/fixedbugs/issue3552.go File test/fixedbugs/issue3552.go (right): https://codereview.appspot.com/6866047/diff/3/test/fixedbugs/issue3552.go#newcode1 test/fixedbugs/issue3552.go:1: // $G $D/$F.dir/one.go && $G $D/$F.dir/two.go || echo BUG:bug434 ...
9 years, 12 months ago (2012-12-03 19:14:35 UTC) #4
lvd2
https://codereview.appspot.com/6866047/diff/3/test/run.go File test/run.go (right): https://codereview.appspot.com/6866047/diff/3/test/run.go#newcode707 test/run.go:707: "fixedbugs/bug345.go": true, // broken this is unrelated?
9 years, 12 months ago (2012-12-03 19:17:40 UTC) #5
remyoudompheng
https://codereview.appspot.com/6866047/diff/3/test/run.go File test/run.go (right): https://codereview.appspot.com/6866047/diff/3/test/run.go#newcode707 test/run.go:707: "fixedbugs/bug345.go": true, // broken yes, I'll revert the change ...
9 years, 12 months ago (2012-12-03 19:23:38 UTC) #6
remyoudompheng
Hello golang-dev@googlegroups.com, lvd@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 12 months ago (2012-12-03 19:23:52 UTC) #7
rsc
https://codereview.appspot.com/6866047/diff/11001/src/cmd/gc/fmt.c File src/cmd/gc/fmt.c (right): https://codereview.appspot.com/6866047/diff/11001/src/cmd/gc/fmt.c#newcode541 src/cmd/gc/fmt.c:541: return fmtprint(fp, "@\"\".%s", p); Why is this right for ...
9 years, 11 months ago (2012-12-06 05:58:55 UTC) #8
remyoudompheng
Hello lvd@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 11 months ago (2012-12-22 10:59:43 UTC) #9
DMorsing
LGTM.
9 years, 11 months ago (2012-12-22 12:58:18 UTC) #10
rsc
LGTM
9 years, 11 months ago (2012-12-22 14:31:04 UTC) #11
remyoudompheng
9 years, 11 months ago (2012-12-22 18:18:14 UTC) #12
*** Submitted as https://code.google.com/p/go/source/detail?r=6a028d6b7222 ***

cmd/gc: fix wrong interaction between inlining and embedded builtins.

The patch makes the compile user an ordinary package-local
symbol for the name of embedded fields of builtin type.

This is incompatible with the fix delivered for issue 2687
(revision 3c060add43fb) but fixes it in a different way, because
the explicit symbol on the field makes the typechecker able to
find it in lookdot.

Fixes issue 3552.

R=lvd, rsc, daniel.morsing
CC=golang-dev
https://codereview.appspot.com/6866047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b