Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(803)

Issue 6865054: Combine and minifiy CSS files.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 12 months ago by benji
Modified:
7 years, 12 months ago
Reviewers:
mp+137650
Visibility:
Public.

Description

Combine and minifiy CSS files. https://code.launchpad.net/~benji/juju-gui/bug-1078978/+merge/137650 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 16

Patch Set 2 : Combine and minifiy CSS files. #

Total comments: 2

Patch Set 3 : Combine and minifiy CSS files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -116 lines) Patch
M Makefile View 1 7 chunks +58 lines, -34 lines 0 comments Download
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/index.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
M app/modules.js View 1 2 chunks +5 lines, -0 lines 0 comments Download
M bin/merge-files View 1 3 chunks +38 lines, -41 lines 0 comments Download
M grunt.js View 1 1 chunk +6 lines, -2 lines 0 comments Download
M lib/merge-files.js View 1 2 3 chunks +37 lines, -30 lines 0 comments Download
M lib/server.js View 1 2 chunks +5 lines, -4 lines 0 comments Download
M lib/templates.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
benji
Please take a look.
7 years, 12 months ago (2012-12-03 18:27:54 UTC) #1
matthew.scott
Request rereview (needs fixes). I have one minor comment about the code, but was unable ...
7 years, 12 months ago (2012-12-03 21:57:20 UTC) #2
bac
Thanks for the changes Benji. I've made some suggestions on making it more understandable. I ...
7 years, 12 months ago (2012-12-04 14:50:11 UTC) #3
benji
Thanks for the good input guys. I have fixed all the issues pointed out (plus ...
7 years, 12 months ago (2012-12-04 17:22:23 UTC) #4
benji
Please take a look.
7 years, 12 months ago (2012-12-04 17:34:12 UTC) #5
matthew.scott
One minor, otherwise good to go. Thanks for the fixes; definitely an overall win. https://codereview.appspot.com/6865054/diff/8001/lib/merge-files.js ...
7 years, 12 months ago (2012-12-04 19:18:19 UTC) #6
benji
Thanks for looking at this again. https://codereview.appspot.com/6865054/diff/8001/lib/merge-files.js File lib/merge-files.js (right): https://codereview.appspot.com/6865054/diff/8001/lib/merge-files.js#newcode26 lib/merge-files.js:26: function extractRelativePaths(s) { ...
7 years, 12 months ago (2012-12-04 20:07:16 UTC) #7
benji
7 years, 12 months ago (2012-12-04 20:09:33 UTC) #8
*** Submitted:

Combine and minifiy CSS files.

R=matthew.scott, bac
CC=
https://codereview.appspot.com/6865054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b