code review 6863058: go.talks/present: remove presentation logic from data s...

go.talks/present: remove presentation logic from data structures

Remove the Template field from Doc, and the Doc field from Section.
The new Render method on Doc wraps the Doc in an anonymous struct that
also contains the template, before passing it to the template iteslf.
The renderElem function wraps Section elements in a similar way.

[adg, 2012-12-05 03:51:58]

Hello campoy@google.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.talks

[dsymonds, 2012-12-05 04:05:29]

LGTM

https://codereview.appspot.com/6863058/diff/6001/pkg/present/parse.go
File pkg/present/parse.go (right):

https://codereview.appspot.com/6863058/diff/6001/pkg/present/parse.go#newcode34
pkg/present/parse.go:34: var data = struct {
could inline this

[adg, 2012-12-05 04:09:15]

*** Submitted as
https://code.google.com/p/go/source/detail?r=e4ca635112a9&repo=talks ***

go.talks/present: remove presentation logic from data structures

Remove the Template field from Doc, and the Doc field from Section.
The new Render method on Doc wraps the Doc in an anonymous struct that
also contains the template, before passing it to the template iteslf.
The renderElem function wraps Section elements in a similar way.

R=campoy, dsymonds
CC=golang-dev
https://codereview.appspot.com/6863058

https://codereview.appspot.com/6863058/diff/6001/pkg/present/parse.go
File pkg/present/parse.go (right):

https://codereview.appspot.com/6863058/diff/6001/pkg/present/parse.go#newcode34
pkg/present/parse.go:34: var data = struct {
On 2012/12/05 04:05:29, dsymonds wrote:
> could inline this

Done.