Issue 6863055: code review 6863055: A+C: Egon Elbre (individual CLA)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6863055: code review 6863055: A+C: Egon Elbre (individual CLA) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by adg

Modified:
12 years, 6 months ago

Reviewers:

CC:
golang-dev, remyoudompheng, iant

Visibility:
Public.

Description

A+C: Egon Elbre (individual CLA)

Patch Set 1 #

Patch Set 2 : diff -r 08462805eb2c https://code.google.com/p/go #

Patch Set 3 : diff -r 08462805eb2c https://code.google.com/p/go #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	AUTHORS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	CONTRIBUTORS	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 6 months ago (2012-12-03 23:04:28 UTC) #1

remyoudompheng

There seems to be a disagreement on whether the name is Elbre or Elbrea in ...

12 years, 6 months ago (2012-12-03 23:06:05 UTC) #2

adg

Hello golang-dev@googlegroups.com, remyoudompheng@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 6 months ago (2012-12-03 23:06:53 UTC) #3

adg

12 years, 6 months ago (2012-12-03 23:14:31 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=b7fd6fe38b63 ***

A+C: Egon Elbre (individual CLA)

R=golang-dev, remyoudompheng, iant
CC=golang-dev
https://codereview.appspot.com/6863055

Expand All Messages | Collapse All Messages