On 2014/02/25 17:31:51, yselivanov wrote: > Aside from one nit lgtm. > > Can we ...
10 years, 2 months ago
(2014-02-25 19:22:21 UTC)
#2
On 2014/02/25 17:31:51, yselivanov wrote:
> Aside from one nit lgtm.
>
> Can we push this after 3.4.0? If something worth merging in 3.4.0 comes up, I
> don't want to make it harder for Larry to cherry-pick.
>
> https://codereview.appspot.com/68620044/diff/1/tests/test_unix_events.py
> File tests/test_unix_events.py (right):
>
>
https://codereview.appspot.com/68620044/diff/1/tests/test_unix_events.py#newc...
> tests/test_unix_events.py:868: new_callable=mock.Mock)
> please fix the indent
Thanks Yuri for the review. LGTM too.
Regarding 3.4.0 vs. 3.4.1, I propose that for Tulip we create a branch off the
0.4.1 tag if we find anything that needs to be cherry-picked into 3.4.0 final --
the Tulip default branch will go into the CPython default branch which will
become CPython 3.4.1.
On 2014/02/26 00:52:22, haypo_gmail wrote: > Yury: are you ok to commit this change in ...
10 years, 2 months ago
(2014-02-26 02:16:03 UTC)
#4
On 2014/02/26 00:52:22, haypo_gmail wrote:
> Yury: are you ok to commit this change in Tulip and Python right now?
By all means ;)
But please fix that indent...
Issue 68620044: Replace unittest.mock with mock
Created 10 years, 2 months ago by haypo_gmail
Modified 10 years, 2 months ago
Reviewers: yselivanov, GvR
Base URL:
Comments: 1