Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15345)

Issue 68620044: Replace unittest.mock with mock

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by haypo_gmail
Modified:
10 years, 2 months ago
Reviewers:
yselivanov, GvR
Visibility:
Public.

Description

Replace unittest.mock with mock

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -386 lines) Patch
M asyncio/test_utils.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/test_base_events.py View 38 chunks +54 lines, -54 lines 0 comments Download
M tests/test_events.py View 11 chunks +16 lines, -16 lines 0 comments Download
M tests/test_futures.py View 6 chunks +8 lines, -8 lines 0 comments Download
M tests/test_locks.py View 8 chunks +10 lines, -10 lines 0 comments Download
M tests/test_proactor_events.py View 24 chunks +39 lines, -39 lines 0 comments Download
M tests/test_queues.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/test_selector_events.py View 65 chunks +135 lines, -135 lines 0 comments Download
M tests/test_selectors.py View 13 chunks +18 lines, -18 lines 0 comments Download
M tests/test_streams.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/test_transports.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/test_unix_events.py View 60 chunks +95 lines, -95 lines 1 comment Download
M tests/test_windows_utils.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
yselivanov
Aside from one nit lgtm. Can we push this after 3.4.0? If something worth merging ...
10 years, 2 months ago (2014-02-25 17:31:51 UTC) #1
GvR
On 2014/02/25 17:31:51, yselivanov wrote: > Aside from one nit lgtm. > > Can we ...
10 years, 2 months ago (2014-02-25 19:22:21 UTC) #2
haypo_gmail
Yury: are you ok to commit this change in Tulip and Python right now?
10 years, 2 months ago (2014-02-26 00:52:22 UTC) #3
yselivanov
10 years, 2 months ago (2014-02-26 02:16:03 UTC) #4
On 2014/02/26 00:52:22, haypo_gmail wrote:
> Yury: are you ok to commit this change in Tulip and Python right now?

By all means ;)
But please fix that indent...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b