code review 68610043: runtime: fix 386, arm build

runtime: fix 386, arm build

CL 68150047 lost runtime.panicdivide.

[rsc, 2014-02-25 16:31:06]

Hello dfc (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2014-02-25 16:31:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=86be37c8d562 ***

runtime: fix 386, arm build

CL 68150047 lost runtime.panicdivide.

TBR=dfc
CC=golang-codereviews
https://codereview.appspot.com/68610043

[bradfitz, 2014-02-25 16:35:37]

LGTM



On Tue, Feb 25, 2014 at 8:31 AM, <rsc@golang.org> wrote:

> Reviewers: dfc,
>
> Message:
> Hello dfc (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> runtime: fix 386, arm build
>
> CL 68150047 lost runtime.panicdivide.
>
> Please review this at https://codereview.appspot.com/68610043/
>
> Affected files (+6, -0 lines):
>   M src/pkg/runtime/panic.c
>
>
> Index: src/pkg/runtime/panic.c
> ===================================================================
> --- a/src/pkg/runtime/panic.c
> +++ b/src/pkg/runtime/panic.c
> @@ -487,3 +487,9 @@
>         rundefer();
>         runtime·goexit();
>  }
> +
> +void
> +runtime·panicdivide(void)
> +{
> +       runtime·panicstring("integer divide by zero");
> +}
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[dave_cheney.net, 2014-02-25 19:52:09]

LGTM. Thanks.

I'm very sorry about the breakage, I did test this CL on 386, I don't know
how this happened.


On Wed, Feb 26, 2014 at 3:35 AM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> LGTM
>
>
>
> On Tue, Feb 25, 2014 at 8:31 AM, <rsc@golang.org> wrote:
>
>> Reviewers: dfc,
>>
>> Message:
>> Hello dfc (cc: golang-codereviews@googlegroups.com),
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go/
>>
>>
>> Description:
>> runtime: fix 386, arm build
>>
>> CL 68150047 lost runtime.panicdivide.
>>
>> Please review this at https://codereview.appspot.com/68610043/
>>
>> Affected files (+6, -0 lines):
>>   M src/pkg/runtime/panic.c
>>
>>
>> Index: src/pkg/runtime/panic.c
>> ===================================================================
>> --- a/src/pkg/runtime/panic.c
>> +++ b/src/pkg/runtime/panic.c
>> @@ -487,3 +487,9 @@
>>         rundefer();
>>         runtime·goexit();
>>  }
>> +
>> +void
>> +runtime·panicdivide(void)
>> +{
>> +       runtime·panicstring("integer divide by zero");
>> +}
>>
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>
>