Update bench_expectations.txt with new codes in issue 6842112.
Rev range is [6580, 6585].
Committed: https://code.google.com/p/skia/source/detail?r=6589
On 2012/11/28 19:58:10, benchen wrote: > https://codereview.appspot.com/6858091 is under review, and this is result > ...
11 years, 9 months ago
(2012-11-28 20:15:28 UTC)
#2
On 2012/11/28 19:58:10, benchen wrote:
> https://codereview.appspot.com/6858091 is under review, and this is result
> generated from the new code.
Rubber stamp LGTM
Thanks for the stamp! Will submit while waiting for the other cl. On 2012/11/28 20:15:28, ...
11 years, 9 months ago
(2012-11-28 20:22:53 UTC)
#3
Thanks for the stamp! Will submit while waiting for the other cl.
On 2012/11/28 20:15:28, EricB wrote:
> On 2012/11/28 19:58:10, benchen wrote:
> > https://codereview.appspot.com/6858091 is under review, and this is result
> > generated from the new code.
>
> Rubber stamp LGTM
A note on this... Looking at the log output here: http://70.32.156.51:10115/builders/Skia_Shuttle_Ubuntu12_ATI5770_Float_Bench_32/builds/473/steps/GenerateBenchGraphs/logs/stdio The step *should* be ...
11 years, 9 months ago
(2012-11-29 19:59:46 UTC)
#5
A note on this... Looking at the log output here:
http://70.32.156.51:10115/builders/Skia_Shuttle_Ubuntu12_ATI5770_Float_Bench_...
The step *should* be failing due to bench values being out of range but instead
there's a try/catch somewhere which is making the assumption that the exception
is due to not having enough data.
This is due to Line 76 of https://code.google.com/p/skia/source/browse/buildbot/slave/skia_slave_scripts/generate_bench_graphs.py Although I prefer the current soft fail ...
11 years, 9 months ago
(2012-11-30 04:46:33 UTC)
#6
On 2012/11/30 04:46:33, benchen wrote: > This is due to Line 76 of > https://code.google.com/p/skia/source/browse/buildbot/slave/skia_slave_scripts/generate_bench_graphs.py ...
11 years, 9 months ago
(2012-11-30 12:42:20 UTC)
#7
Message was sent while issue was closed.
On 2012/11/30 04:46:33, benchen wrote:
> This is due to Line 76 of
>
https://code.google.com/p/skia/source/browse/buildbot/slave/skia_slave_script...
> Although I prefer the current soft fail before we confirm that we should
really
> make everyone panic with our alert triggering algorithm.
>
> On 2012/11/29 19:59:46, EricB wrote:
> > A note on this... Looking at the log output here:
> >
>
http://70.32.156.51:10115/builders/Skia_Shuttle_Ubuntu12_ATI5770_Float_Bench_...
> >
> > The step *should* be failing due to bench values being out of range but
> instead
> > there's a try/catch somewhere which is making the assumption that the
> exception
> > is due to not having enough data.
I think that's fine for now. I just wanted to make sure we were aware of it.
Issue 6858091: Update bench_expectations.txt with new codes in issue 6842112.
(Closed)
Created 11 years, 9 months ago by benchen
Modified 11 years, 9 months ago
Reviewers: epoger, EricB
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0