Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3398)

Issue 6858091: Update bench_expectations.txt with new codes in issue 6842112. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by benchen
Modified:
12 years ago
Reviewers:
epoger, EricB
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Update bench_expectations.txt with new codes in issue 6842112. Rev range is [6580, 6585]. Committed: https://code.google.com/p/skia/source/detail?r=6589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2059 lines, -2059 lines) Patch
M bench/bench_expectations.txt View 1 chunk +2059 lines, -2059 lines 0 comments Download

Messages

Total messages: 7
benchen
https://codereview.appspot.com/6858091 is under review, and this is result generated from the new code.
12 years ago (2012-11-28 19:58:10 UTC) #1
EricB
On 2012/11/28 19:58:10, benchen wrote: > https://codereview.appspot.com/6858091 is under review, and this is result > ...
12 years ago (2012-11-28 20:15:28 UTC) #2
benchen
Thanks for the stamp! Will submit while waiting for the other cl. On 2012/11/28 20:15:28, ...
12 years ago (2012-11-28 20:22:53 UTC) #3
epoger
LGTM
12 years ago (2012-11-29 19:55:52 UTC) #4
EricB
A note on this... Looking at the log output here: http://70.32.156.51:10115/builders/Skia_Shuttle_Ubuntu12_ATI5770_Float_Bench_32/builds/473/steps/GenerateBenchGraphs/logs/stdio The step *should* be ...
12 years ago (2012-11-29 19:59:46 UTC) #5
benchen
This is due to Line 76 of https://code.google.com/p/skia/source/browse/buildbot/slave/skia_slave_scripts/generate_bench_graphs.py Although I prefer the current soft fail ...
12 years ago (2012-11-30 04:46:33 UTC) #6
EricB
12 years ago (2012-11-30 12:42:20 UTC) #7
Message was sent while issue was closed.
On 2012/11/30 04:46:33, benchen wrote:
> This is due to Line 76 of
>
https://code.google.com/p/skia/source/browse/buildbot/slave/skia_slave_script...
> Although I prefer the current soft fail before we confirm that we should
really
> make everyone panic with our alert triggering algorithm.
> 
> On 2012/11/29 19:59:46, EricB wrote:
> > A note on this... Looking at the log output here:
> >
>
http://70.32.156.51:10115/builders/Skia_Shuttle_Ubuntu12_ATI5770_Float_Bench_...
> > 
> > The step *should* be failing due to bench values being out of range but
> instead
> > there's a try/catch somewhere which is making the assumption that the
> exception
> > is due to not having enough data.

I think that's fine for now.  I just wanted to make sure we were aware of it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b